Skip to content

ci: Delete cilium-node-init ds before cilium install#12725

Merged
nebril merged 1 commit intomasterfrom
pr/delete-node-init-ci
Jul 30, 2020
Merged

ci: Delete cilium-node-init ds before cilium install#12725
nebril merged 1 commit intomasterfrom
pr/delete-node-init-ci

Conversation

@nebril
Copy link
Copy Markdown
Member

@nebril nebril commented Jul 30, 2020

--validate helm flag introduced in 82cc7c3 caused ci to fail in gke
where we enable node init daemonset. It needs to be cleared before
cilium installation.

@nebril nebril requested a review from a team as a code owner July 30, 2020 18:14
@maintainer-s-little-helper maintainer-s-little-helper Bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 30, 2020
@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jul 30, 2020

test-gke

@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jul 30, 2020

test-4.9

@nebril nebril added the release-note/ci This PR makes changes to the CI. label Jul 30, 2020
@maintainer-s-little-helper maintainer-s-little-helper Bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 30, 2020
christarazi
christarazi approved these changes Jul 30, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@nebril
ci: Delete cilium-node-init ds before cilium install
5752e65 
`--validate` helm flag introduced in 82cc7c3 caused ci to fail in gke
where we enable node init daemonset. It needs to be cleared before
cilium installation.

Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril nebril force-pushed the pr/delete-node-init-ci branch from f1b3fcb to 5752e65 Compare July 30, 2020 18:39
@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jul 30, 2020

test-gke

@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jul 30, 2020

test-4.9

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 30, 2020

Coverage Status

Coverage increased (+0.008%) to 36.666% when pulling 5752e65 on pr/delete-node-init-ci into eb2b708 on master.

@gandro gandro mentioned this pull request Jul 30, 2020
Merged
@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jul 30, 2020

Only tests that failed were ones that will be fixed by #12709 , merging

@nebril nebril merged commit 208ef7a into master Jul 30, 2020
@nebril nebril deleted the pr/delete-node-init-ci branch July 30, 2020 20:44
@nebril nebril mentioned this pull request Aug 3, 2020
Closed
@fristonio fristonio mentioned this pull request Aug 3, 2020
Merged
@joestringer joestringer mentioned this pull request Oct 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christarazi christarazi christarazi approved these changes

Assignees

No one assigned

Labels

release-note/ci This PR makes changes to the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nebril @coveralls @christarazi