Skip to content

Makefile: process packages in subshells for bench targets#12607

Merged
rolinh merged 1 commit intomasterfrom
pr/tklauser/fix-make-bench-targets
Jul 22, 2020
Merged

Makefile: process packages in subshells for bench targets#12607
rolinh merged 1 commit intomasterfrom
pr/tklauser/fix-make-bench-targets

Conversation

@tklauser
Copy link
Copy Markdown
Member

In certain environments, the argument list might become large enough so
make bench or make bench-privileged fail with:

make: execvp: /bin/bash: Argument list too long

Follow the approach from commit cfa665d ("Explicitly break
unit-tests foreach into for loop.") for the bench and
bench-privileged targets as well to fix this.

In certain environments, the argument list might become large enough so
`make bench` or `make bench-privileged` fail with:

  make: execvp: /bin/bash: Argument list too long

Follow the approach from commit cfa665d ("Explicitly break
unit-tests foreach into for loop.") for the `bench` and
`bench-privileged` targets as well to fix this.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser added release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.8 labels Jul 21, 2020
@tklauser tklauser requested a review from a team as a code owner July 21, 2020 14:59
@tklauser
Copy link
Copy Markdown
Member Author

No need to run Jenkins CI for this PR as these make targets are not exercised.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.01%) to 36.982% when pulling c127982 on pr/tklauser/fix-make-bench-targets into 1173f18 on master.

@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 22, 2020
@rolinh rolinh merged commit 599c3af into master Jul 22, 2020
@rolinh rolinh deleted the pr/tklauser/fix-make-bench-targets branch July 22, 2020 08:43
@tklauser
Copy link
Copy Markdown
Member Author

No need to run Jenkins CI as per #12607 (comment), marking as ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants