Skip to content

k8s/watchers: stop init of local endpoint in success case#12595

Merged
aanm merged 1 commit intomasterfrom
pr/do-not-init-in-success
Jul 20, 2020
Merged

k8s/watchers: stop init of local endpoint in success case#12595
aanm merged 1 commit intomasterfrom
pr/do-not-init-in-success

Conversation

@aanm
Copy link
Copy Markdown
Member

@aanm aanm commented Jul 20, 2020 •
edited
Loading

If we can get a local copy of the CEP we no longer need to keep getting
it from Kubernetes.

Fixes: 469475b ("watchers/endpointsynchronizer: do not delete CEP on initialization")
Signed-off-by: André Martins andre@cilium.io

avoid performing useless GETs of Cilium Endpoints

@aanm
k8s/watchers: stop init of local endpoint in success case
c7aad69 
If we can get a local copy of the CEP we no longer need to keep getting
it from Kubernetes.

Fixes: 469475b ("watchers/endpointsynchronizer: do not delete CEP on initialization")
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added the area/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. label Jul 20, 2020
@aanm aanm requested a review from a team July 20, 2020 15:39
@maintainer-s-little-helper maintainer-s-little-helper Bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 20, 2020
@aanm aanm added kind/regression This functionality worked fine before, but was broken in a newer release of Cilium. needs-backport/1.8 release-note/bug This PR fixes an issue in a previous release of Cilium. and removed area/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. labels Jul 20, 2020
@maintainer-s-little-helper maintainer-s-little-helper Bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 20, 2020
@aanm
Copy link
Copy Markdown
Member Author

aanm commented Jul 20, 2020

test-me-please

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 20, 2020

Coverage Status

Coverage decreased (-0.04%) to 36.976% when pulling c7aad69 on pr/do-not-init-in-success into 2e1859c on master.

christarazi
christarazi approved these changes Jul 20, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor nit on release note, I find them easier to read by stating the positive action rather than the negated acion, i.e. Avoid useless GETs .... This is a preference so feel free to ignore :)

@maintainer-s-little-helper maintainer-s-little-helper Bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 20, 2020
@aanm aanm merged commit a2e2fed into master Jul 20, 2020
@aanm aanm deleted the pr/do-not-init-in-success branch July 20, 2020 19:49
@pchaigno pchaigno mentioned this pull request Jul 21, 2020
Merged
@aanm aanm mentioned this pull request Sep 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christarazi christarazi christarazi approved these changes

Assignees

No one assigned

Labels

kind/regression This functionality worked fine before, but was broken in a newer release of Cilium. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aanm @coveralls @christarazi @pchaigno