Skip to content

docs: Clarify that identity transfer is an optimization#12589

Merged
rolinh merged 2 commits intomasterfrom
pr/pchaigno/minor-clarification-identity-transfer
Jul 21, 2020
Merged

docs: Clarify that identity transfer is an optimization#12589
rolinh merged 2 commits intomasterfrom
pr/pchaigno/minor-clarification-identity-transfer

Conversation

@pchaigno
Copy link
Copy Markdown
Member

@pchaigno pchaigno commented Jul 20, 2020

This small change should clarify that the identity transfer in overlay mode is an optimization and not a requirement. We have had several users confused by this paragraph asking how security identity was obtained in direct routing mode.

@pchaigno pchaigno added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Jul 20, 2020
@pchaigno pchaigno requested a review from a team as a code owner July 20, 2020 13:03
pchaigno
pchaigno commented Jul 20, 2020
View reviewed changes
Comment thread Documentation/concepts/networking/routing.rst Outdated
@coveralls
Copy link
Copy Markdown

coveralls commented Jul 20, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 37.012% when pulling 86ea1f7 on pr/pchaigno/minor-clarification-identity-transfer into 3063fee on master.

@pchaigno pchaigno requested a review from brb July 20, 2020 16:30
brb
brb requested changes Jul 21, 2020
View reviewed changes
Comment thread Documentation/concepts/networking/routing.rst Outdated
pchaigno added 2 commits July 21, 2020 10:40
@pchaigno
docs: Remove mention of state transfer for DSR
77b99e7 
7796070 removed bpf_lb.o and any LB state transfers across nodes for
DSR.

Fixes: 7796070 ("bpf: Remove bpf_lb.c")
Reported-by: Martynas Pumputis <m@lambda.lt>
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno
docs: Clarify that identity transfer is an optimization
86ea1f7 
This small change should clarify that the identity transfer in overlay
mode is an optimization and not a requirement. We have had several users
confused by this paragraph asking how security identity was obtained in
direct routing mode.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno force-pushed the pr/pchaigno/minor-clarification-identity-transfer branch from 69bed4a to 86ea1f7 Compare July 21, 2020 08:40
@pchaigno pchaigno requested a review from brb July 21, 2020 08:41
@pchaigno pchaigno added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. needs-backport/1.8 labels Jul 21, 2020
@rolinh rolinh merged commit 7930f74 into master Jul 21, 2020
@rolinh rolinh deleted the pr/pchaigno/minor-clarification-identity-transfer branch July 21, 2020 10:47
@pchaigno pchaigno mentioned this pull request Jul 23, 2020
Merged
@aditighag aditighag mentioned this pull request Dec 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brb brb brb approved these changes

@rolinh rolinh rolinh approved these changes

@aanm aanm aanm approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees

No one assigned

Labels

area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pchaigno @coveralls @brb @rolinh @aanm @qmonnet @christarazi