Conversation
Maciej reported that when using vxlan packets we can see a TTL of 64 in the packet while for geneve packets the TTL is set to 0. This is a kernel issue in that vxlan driver in its vxlan_xmit_one() routine derives TTL from the route if otherwise not explicitly set (such as by BPF tunnel key): ttl = ttl ? : ip4_dst_hoplimit(&rt->dst); In geneve driver however, geneve_xmit_skb() only does the above in non-collect_md mode, which means, if not explicitly set, the TTL will remain 0 here. I'll post a kernel fix separately, but simple workaround is to just set TTL in BPF tunnel key to fixed value of 64. tunnel_ttl is part of 4.9 bpf uapi header, so there are no issues with backwards compat. Reported-by: Maciej Skrocki <maciejskrocki@google.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Member
Author
|
test-me-please |
pchaigno
approved these changes
Jul 15, 2020
brb
approved these changes
Jul 15, 2020
qmonnet
approved these changes
Jul 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit msg for details. Cc: @mskrocki