clustermesh: Tidy up services connection on failure to reconnect#12526
Merged
qmonnet merged 1 commit intocilium:masterfrom Jul 15, 2020
Merged
Conversation
In the case where there is a failure to watch remote identities from the peer cluster, we would not close out the connection to the services store properly. Fix it up. The context usage in this code should also be investigated more closely but we can fix that up in a subsequent commit. Fixes: f28f6cd ("clustermesh: Use remote kvstore backend") Signed-off-by: Joe Stringer <joe@cilium.io>
Member
Author
|
Given that this is clustermesh-only code and AFAIK we don't have any e2e tests for clustermesh, I presume that code review + GH smoke tests should provide all of the coverage we need to proceed with this commit. Not running main CI. |
tgraf
approved these changes
Jul 14, 2020
qmonnet
approved these changes
Jul 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case where there is a failure to watch remote identities from the
peer cluster when reconnecting to a peer cluster, we would not close
out the connection to the services store properly. Fix it up.
The context usage in this code should also be investigated more closely
but we can fix that up in a subsequent commit.
Fixes: f28f6cd ("clustermesh: Use remote kvstore backend")