Adds documentation for limiting identity-relevant labels used when evaluating Cilium Identities#12517
Merged
qmonnet merged 2 commits intocilium:masterfrom Jul 15, 2020
seanmwinn:cilium-11540
Merged
Adds documentation for limiting identity-relevant labels used when evaluating Cilium Identities#12517qmonnet merged 2 commits intocilium:masterfrom seanmwinn:cilium-11540
qmonnet merged 2 commits intocilium:masterfrom
seanmwinn:cilium-11540
Conversation
Fixes: #11540 Signed-off-by: Sean Winn <sean@isovalent.com>
pchaigno
reviewed
Jul 13, 2020
Member
pchaigno
left a comment
There was a problem hiding this comment.
Looks great! Mostly nits below from me :-)
Signed-off-by: Sean Winn <sean@isovalent.com>
pchaigno
approved these changes
Jul 14, 2020
qmonnet
approved these changes
Jul 15, 2020
Member
|
Seeing that this is marked for backports, but that |
This was referenced Jul 21, 2020
Member
|
This PR has two commits which should have been squashed into one. We should look out for things like this next time before merging. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds documentation for limiting identity-relevant labels used when evaluating Cilium Identities
Fixes: #11540
Signed-off-by: Sean Winn sean@isovalent.com