.travis:fix up PodCIDRSuite failure on Arm64#12504
Merged
qmonnet merged 1 commit intocilium:masterfrom Jul 17, 2020
Merged
Conversation
joestringer
reviewed
Jul 14, 2020
Member
joestringer
left a comment
There was a problem hiding this comment.
Is it the mutex that fixes this issue or the move into the select statement?
I think that previously, if there was a timeout for the 5s but the nodes got into the right state, it should (1) perform this check and (2) pass, although it prints an error via c.Error(). Now this check is not performed in the timeout case.
Add mutex to protect the situation that invoke c.Assert before ciliumNodesToK8s be deleted. Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com>
8328e98 to
f6454b8
Compare
Contributor
Author
Mutex fixes this issue. |
joestringer
approved these changes
Jul 16, 2020
qmonnet
approved these changes
Jul 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add mutex to protect the situation that invoke
c.Assert before ciliumNodesToK8s be deleted.
Signed-off-by: Jianlin Lv Jianlin.Lv@arm.com
Fixes: #12306