Skip to content

cilium: hostport follow-up#12492

Merged
borkmann merged 1 commit intomasterfrom
pr/simplify-hostport-gen
Jul 10, 2020
Merged

cilium: hostport follow-up#12492
borkmann merged 1 commit intomasterfrom
pr/simplify-hostport-gen

Conversation

@borkmann
Copy link
Copy Markdown
Member

See commit msg @brb

Do not convert the loopback address into a surrogate, but instead, if
explicitly selected, ignore it and dump a warning message to the agent
log. Converting to surrogate is not comparable given this would also
allow _local_ Pods to connect via the Node's IP.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann borkmann added pending-review release-note/misc This PR makes changes that have no direct user impact. labels Jul 10, 2020
@borkmann borkmann requested a review from brb July 10, 2020 12:09
@borkmann borkmann requested a review from a team as a code owner July 10, 2020 12:09
@borkmann borkmann requested a review from a team July 10, 2020 12:09
@borkmann
Copy link
Copy Markdown
Member Author

test-me-please

@borkmann borkmann merged commit 7e6a7bb into master Jul 10, 2020
@borkmann borkmann deleted the pr/simplify-hostport-gen branch July 10, 2020 14:06
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.008%) to 36.968% when pulling 1c2633a on pr/simplify-hostport-gen into d88d5f9 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants