Skip to content

helm: update notes to include Hubble Relay#12486

Merged
qmonnet merged 1 commit intomasterfrom
pr/rolinh/helm-hubble-message
Jul 15, 2020
Merged

helm: update notes to include Hubble Relay#12486
qmonnet merged 1 commit intomasterfrom
pr/rolinh/helm-hubble-message

Conversation

@rolinh
Copy link
Copy Markdown
Member

@rolinh rolinh commented Jul 10, 2020

This commit updates the NOTES.txt template to ensure that the user is informed when Hubble Relay is installed be it with or without Hubble UI.

@rolinh rolinh added release-note/misc This PR makes changes that have no direct user impact. area/hubble area/helm Impacts helm charts and user deployment experience labels Jul 10, 2020
@rolinh rolinh requested review from a team as code owners July 10, 2020 07:31
@rolinh rolinh requested a review from a team July 10, 2020 07:31
@coveralls
Copy link
Copy Markdown

coveralls commented Jul 10, 2020

Coverage Status

Coverage decreased (-0.03%) to 36.962% when pulling fc42954 on pr/rolinh/helm-hubble-message into c4b2c1e on master.

Comment thread install/kubernetes/cilium/templates/NOTES.txt Outdated
Copy link
Copy Markdown
Member

@nebril nebril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit from @sayboras is valid but not blocking IMO (especially since it was already there).

This commit updates the NOTES.txt template to ensure that the user is
informed when Hubble Relay is installed be it with or without Hubble UI.

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
@rolinh rolinh force-pushed the pr/rolinh/helm-hubble-message branch from b7657d4 to fc42954 Compare July 13, 2020 11:24
@rolinh rolinh added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 14, 2020
@qmonnet qmonnet merged commit affdaa8 into master Jul 15, 2020
@qmonnet qmonnet deleted the pr/rolinh/helm-hubble-message branch July 15, 2020 08:29
@brb brb mentioned this pull request Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/helm Impacts helm charts and user deployment experience ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants