Skip to content

Document kvstore leases, update links#12481

Merged
joestringer merged 2 commits intocilium:masterfrom
joestringer:submit/document-kvstore-leases
Jul 10, 2020
Merged

Document kvstore leases, update links#12481
joestringer merged 2 commits intocilium:masterfrom
joestringer:submit/document-kvstore-leases

Conversation

@joestringer
Copy link
Copy Markdown
Member

  • Update the kvstore code links to pkg.go.dev
  • List the objects by lease-ID with lease/GC behaviour in a nice table

@joestringer joestringer added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.8 labels Jul 9, 2020
@joestringer joestringer requested a review from a team July 9, 2020 21:04
@joestringer joestringer requested a review from a team as a code owner July 9, 2020 21:04
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.01%) to 36.963% when pulling 8f77722dc884ba0549e6937396c550778cf3e314 on joestringer:submit/document-kvstore-leases into b5f633a on cilium:master.

1 similar comment
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.01%) to 36.963% when pulling 8f77722dc884ba0549e6937396c550778cf3e314 on joestringer:submit/document-kvstore-leases into b5f633a on cilium:master.

Copy link
Copy Markdown
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit. LGTM otherwise!

Comment thread Documentation/kvstore.rst Outdated
godoc.org now points visitors towards pkg.go.dev, so we may as well
point to the new site directly rather than pointing to the old one.

Signed-off-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer force-pushed the submit/document-kvstore-leases branch from 8f77722 to 751b892 Compare July 10, 2020 18:28
@joestringer
Copy link
Copy Markdown
Member Author

Docs check passed, docs-only change. Merging.

@joestringer joestringer merged commit c4b2c1e into cilium:master Jul 10, 2020
@joestringer joestringer deleted the submit/document-kvstore-leases branch July 10, 2020 18:33
@brb brb mentioned this pull request Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants