Makefile: Fix render-docs with parallel make jobs#12480
Merged
joestringer merged 1 commit intocilium:masterfrom Jul 10, 2020
Merged
Makefile: Fix render-docs with parallel make jobs#12480joestringer merged 1 commit intocilium:masterfrom
joestringer merged 1 commit intocilium:masterfrom
Conversation
When running make with parallel jobs (make -j N), the ordering between the build of the html and running the server was not guaranteed. Split them into separate make commands in the target to ensure the build happens first. Signed-off-by: Joe Stringer <joe@cilium.io>
aanm
approved these changes
Jul 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running make with parallel jobs (make -j N), the ordering between
the build of the html and running the server was not guaranteed. Split
them into separate make commands in the target to ensure the build
happens first.