Skip to content

test: retrieve pods based on node label, not name#12398

Merged
nebril merged 1 commit intomasterfrom
pr/get-pods-by-node-label
Jul 3, 2020
Merged

test: retrieve pods based on node label, not name#12398
nebril merged 1 commit intomasterfrom
pr/get-pods-by-node-label

Conversation

@nebril
Copy link
Copy Markdown
Member

@nebril nebril commented Jul 3, 2020

This change removes reliance on hardcoded node names when retrieving
pods in several tests, which caused GKE tests (where we don't control
node names) to fail.

@nebril nebril requested a review from a team as a code owner July 3, 2020 09:13
@maintainer-s-little-helper maintainer-s-little-helper Bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 3, 2020
@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jul 3, 2020

test-gke

@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jul 3, 2020

test-4.9

@nebril nebril added the release-note/ci This PR makes changes to the CI. label Jul 3, 2020
@maintainer-s-little-helper maintainer-s-little-helper Bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 3, 2020
@coveralls
Copy link
Copy Markdown

coveralls commented Jul 3, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 36.916% when pulling a21dbb9 on pr/get-pods-by-node-label into a8eb67d on master.

@nebril
test: retrieve pods based on node label, not name
a21dbb9 
This change removes reliance on hardcoded node names when retrieving
pods in several tests, which caused GKE tests (where we don't control
node names) to fail.

Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril nebril force-pushed the pr/get-pods-by-node-label branch from d8e7443 to a21dbb9 Compare July 3, 2020 11:12
@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jul 3, 2020

test-gke K8s(Policy|Service)

@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jul 3, 2020

test-4.9

@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jul 3, 2020

test-net-next

@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jul 3, 2020

test-4.19

@nebril nebril merged commit 082e879 into master Jul 3, 2020
@nebril nebril deleted the pr/get-pods-by-node-label branch July 3, 2020 22:15
@vadorovsky vadorovsky mentioned this pull request Jul 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tgraf tgraf tgraf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note/ci This PR makes changes to the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nebril @coveralls @tgraf @joestringer @qmonnet @vadorovsky