endpoint: atomically replace header files#12380
Merged
Conversation
Member
Author
|
test-me-please |
pchaigno
requested changes
Jul 2, 2020
Member
pchaigno
left a comment
There was a problem hiding this comment.
One comment below for downgrade case. LGTM otherwise!
4037d23 to
52c81e5
Compare
Member
Author
|
test-me-please |
pchaigno
reviewed
Jul 2, 2020
52c81e5 to
652429e
Compare
Member
Author
|
test-me-please |
pchaigno
approved these changes
Jul 2, 2020
Member
Author
|
retest-net-next (vm provisioning fail: https://jenkins.cilium.io/job/Cilium-PR-K8s-oldest-net-next/1075) |
aanm
requested changes
Jul 2, 2020
Write contents of the header file to a temporary file first. It will then be atomically renamed to the real file. This makes sure we never end up with corrupted on inconsistent header files on the filesystem. Also make sure the symlink to the old header file in the downgrade case is created atomically. The github.com/google/renameio package is used for the atomic replace and symlink creation. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
652429e to
93d38c7
Compare
Member
Author
|
test-me-please |
aanm
approved these changes
Jul 2, 2020
ianvernon
approved these changes
Jul 2, 2020
This was referenced Jul 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Write contents of the header file to a temporary file first. It will
then be atomically renamed to the real file. This makes sure we never
end up with corrupted on inconsistent header files on the filesystem.
The github.com/google/renameio package is used for the atomic replace.
For #12367