gitignore: Add test/gke/registry-adder.yaml#12342
Merged
Conversation
(GKE) Builds fail now if there are any untracked, non-ignored files in the source tree. Fix this by adding test/gke/registry-adder.yaml into .gitignore. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
Remove the generated temp files after they are no longer needed. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
Member
Author
|
test-gke |
1 similar comment
Member
Author
|
test-gke |
aanm
approved these changes
Jul 1, 2020
nebril
approved these changes
Jul 1, 2020
Member
|
@jrajahalme is this user-facing? Typically if a change is not user-facing we'll mark it as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(GKE) Builds fail now if there are any untracked, non-ignored files in the source tree.
Fix this by adding test/gke/registry-adder.yaml into .gitignore and deleting it in
release-cluster.sh.
Note: This was a race between the parallel step of building cilium images and selecting
the cluster. If cluster selection created the registry-adder.yaml before the build was
finished, the build would find an untracked file and fail.
Signed-off-by: Jarno Rajahalme jarno@covalent.io