make: fix LOCKDEBUG env variable reference for docker-plugin-image#12318
Merged
make: fix LOCKDEBUG env variable reference for docker-plugin-image#12318
Conversation
tklauser
approved these changes
Jun 29, 2020
Member
Author
I managed to come up with yet another typo in the commit description... 🤦 Oh well 😛 |
This commit fixes a typo that prevents LOCKDEBUG from working for the `docker-plugin-image` make target. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
e2731cb to
9ff4a38
Compare
Member
|
@rolinh Is this covered by any e2e test? |
Member
Author
|
@pchaigno I don't think so which is why I didn't trigger the whole test suite. |
Member
|
Let's merge then! |
Member
|
Just wanted to mention that I appreciate your backporting note. It saved me time & effort while doing 1.7 backports. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a typo that prevents LOCKDEBUG from working for the
docker-plugin-imagemake target.Note for backporters: in v1.7, the change has to be applied on
Makefile. Look forLOCKDEUBGand replace it.