Skip to content

ci: Check for gke nodepool before locking cluster#12301

Merged
nebril merged 1 commit intomasterfrom
pr/gke-check-nodepools
Jul 1, 2020
Merged

ci: Check for gke nodepool before locking cluster#12301
nebril merged 1 commit intomasterfrom
pr/gke-check-nodepools

Conversation

@nebril
Copy link
Copy Markdown
Member

@nebril nebril commented Jun 26, 2020

If the cluster has just been recreated, it can have no nodepool yet.
Don't choose such clusters because scaling it will fail.

@nebril nebril requested a review from a team as a code owner June 26, 2020 11:54
@maintainer-s-little-helper
Copy link
Copy Markdown

maintainer-s-little-helper Bot commented Jun 26, 2020

Please set the appropriate release note label.

@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jun 26, 2020

test-gke K8sDemos

@nebril nebril added needs-backport/1.8 release-note/ci This PR makes changes to the CI. labels Jun 26, 2020
@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jun 26, 2020

test-gke K8sDemos

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 26, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 36.949% when pulling 37dde93d2ad9f46dd79c582b512668da96ccb5c6 on pr/gke-check-nodepools into 589b56f on master.

@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jun 26, 2020

test-gke K8sDemos

@aanm
Copy link
Copy Markdown
Member

aanm commented Jun 29, 2020

The error looks odd:

16:55:07  #18 DONE 0.3s
16:55:07  docker tag cilium/hubble-relay:5d82d5084a83d2bbe06c7cc87eacd9fb7c7c90f8 cilium/hubble-relay:5d82d5084a83d2bbe06c7cc87eacd9fb7c7c90f8-amd64
16:55:07  Push like this when ready:
16:55:07  docker push cilium/hubble-relay:5d82d5084a83d2bbe06c7cc87eacd9fb7c7c90f8-amd64
16:55:07  make docker-operator-image
16:55:07  make[1]: Entering directory '/home/jenkins/workspace/Cilium-PR-K8s-GKE@2/src/github.com/cilium/cilium'
16:55:07  HEAD detached at 5d82d5084a
16:55:07  Untracked files:
16:55:07    (use "git add <file>..." to include in what will be committed)
16:55:07  
16:55:07  	test/gke/registry-adder.yaml
16:55:07  
16:55:07  nothing added to commit but untracked files present (use "git add" to track)
16:55:07  These changes will not be included in build, aborting. Define IGNORE_GIT_STATUS to build anyway.
16:55:07  Makefile.buildkit:73: recipe for target 'check-status' failed
16:55:07  make[1]: *** [check-status] Error 1
16:55:07  make[1]: Leaving directory '/home/jenkins/workspace/Cilium-PR-K8s-GKE@2/src/github.com/cilium/cilium'
16:55:07  Makefile.docker:16: recipe for target 'docker-image' failed
16:55:07  make: *** [docker-image] Error 2

@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jun 30, 2020

test-gke K8sDemos

@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jun 30, 2020

Seems like this is caused by setting DOCKER_BUILDKIT to 1

@nebril nebril force-pushed the pr/gke-check-nodepools branch from 337558a to 37dde93 Compare June 30, 2020 14:40
@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jun 30, 2020

test-gke K8sDemos

@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jul 1, 2020

test-4.9

@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jul 1, 2020

gke error happens after what this PR fixes, so all good from this side. running 4.9 build to make sure nothing else break, after that it's good to merge

@jrajahalme
Copy link
Copy Markdown
Member

jrajahalme commented Jul 1, 2020

On GKE test cilium-node-init is in ImagePullBackOff because startup-script is not available from the same hub as the cilium itself:

07:51:38  	 cilium              cilium-node-init-hmn5w                                      0/1     ImagePullBackOff   0          5m30s   10.128.0.10   gke-cilium-ci-16-cilium-ci-16-f02f6524-xqsp   <none>           <none>

This error is unrelated to this PR.

jrajahalme
jrajahalme approved these changes Jul 1, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jrajahalme jrajahalme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GKE test successfully passed cluster selection, so this is good to merge.

jrajahalme
jrajahalme requested changes Jul 1, 2020
View reviewed changes
Comment thread test/make-images-push-to-local-registry.sh Outdated
@nebril
ci: Check for gke nodepool before locking cluster
07b1cde 
If the cluster has just been recreated, it can have no nodepool yet.
Don't choose such clusters because scaling it will fail.

Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril nebril force-pushed the pr/gke-check-nodepools branch from 37dde93 to 07b1cde Compare July 1, 2020 08:25
@nebril nebril requested a review from a team as a code owner July 1, 2020 08:25
@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jul 1, 2020

test-gke K8sDemos

@nebril nebril merged commit 269c985 into master Jul 1, 2020
@nebril nebril deleted the pr/gke-check-nodepools branch July 1, 2020 08:48
@vadorovsky vadorovsky mentioned this pull request Jul 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrajahalme jrajahalme jrajahalme approved these changes

Assignees

No one assigned

Labels

release-note/ci This PR makes changes to the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nebril @coveralls @aanm @jrajahalme @joestringer @qmonnet @vadorovsky