Merged
Conversation
|
Please set the appropriate release note label. |
Member
Author
|
test-gke K8sDemos |
jrajahalme
approved these changes
Jun 24, 2020
Contributor
|
@nebril how quickly do they get re-created? |
Member
Author
|
@errordeveloper from my testing - it takes around 10 minutes for cluster to get back up |
Member
Author
|
test-gke K8sDemos |
c00e03b to
bd9c9f6
Compare
We are hitting a lot of issues caused by state left over from test run. This change deletes the cluster after the test run and relies on our infra recreating the cluster for subsequent builds. Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
bd9c9f6 to
d2581cc
Compare
Member
Author
|
swapped the order of commands, we delete the cluster first so we don't rely on config connector deleting the cluster (there were issues related to that before), then we delete the k8s object which will be recreated which will cause cluster to be recreated |
Member
Author
|
test-gke K8sDemos |
errordeveloper
approved these changes
Jun 25, 2020
Member
Author
|
This change is only GKE-related, merging. |
Member
|
I think it might need a backport to 1.8 - we already want to backport GKE changes which depend on this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are hitting a lot of issues caused by state left over from test run.
This change deletes the cluster after the test run and relies on our
infra recreating the cluster for subsequent builds.
From my testing it takes our infra around10 minutes to get the cluster back up after deletion.