Skip to content

build: install gops binary in operator images#12254

Merged
aanm merged 1 commit intomasterfrom
pr/tklauser/operator-images-add-gops
Jun 25, 2020
Merged

build: install gops binary in operator images#12254
aanm merged 1 commit intomasterfrom
pr/tklauser/operator-images-add-gops

Conversation

@tklauser
Copy link
Copy Markdown
Member

We embed gops into the operator binaries, so it makes sense to have the
gops binary in the operator images as well in order to simplify
debugging and/or profiling.

@tklauser tklauser added release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.8 labels Jun 24, 2020
@tklauser tklauser requested a review from a team as a code owner June 24, 2020 09:13
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 24, 2020

Coverage Status

Coverage increased (+0.02%) to 37.177% when pulling c994595 on pr/tklauser/operator-images-add-gops into 55dd1b9 on master.

@rolinh
Copy link
Copy Markdown
Member

rolinh commented Jun 24, 2020

At which step is the gops binary copied over to the final image?

We embed gops into the operator binaries, so it makes sense to have the
gops binary in the operator images as well in order to simplify
debugging and/or profiling.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser force-pushed the pr/tklauser/operator-images-add-gops branch from e1842de to c994595 Compare June 24, 2020 10:59
@tklauser
Copy link
Copy Markdown
Member Author

test-me-please

@tklauser
Copy link
Copy Markdown
Member Author

tklauser commented Jun 25, 2020

retest-net-next (previous failure: https://jenkins.cilium.io/job/Cilium-PR-K8s-oldest-net-next/963, created #12281 to track)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants