cilium: fix helm usage of enableIdentityMap -> enableIdentityMark#12194
Merged
joestringer merged 1 commit intomasterfrom Jun 19, 2020
Merged
cilium: fix helm usage of enableIdentityMap -> enableIdentityMark#12194joestringer merged 1 commit intomasterfrom
joestringer merged 1 commit intomasterfrom
Conversation
Fix the helm usage of enableIdentityMap so that it uses the correct cilium-agent variable enableIdentityMark. Additionally add text in Calico guide for CNI chaining to use the field. Signed-off-by: John Fastabend <john.fastabend@gmail.com>
|
Commit cfc32e4342979d5b5b2da3ea8eb127a3f3c41140 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
|
Please set the appropriate release note label. |
|
Please set the appropriate release note label. |
|
Commit cfc32e4342979d5b5b2da3ea8eb127a3f3c41140 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Contributor
Author
|
Marking with release blocker to force folks to look at this at least before rolling a release. |
Contributor
Author
|
Fixes to mangled helm names here, |
joestringer
approved these changes
Jun 19, 2020
Member
|
test-me-please |
christarazi
approved these changes
Jun 19, 2020
This was referenced Jul 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the helm usage of enableIdentityMap so that it uses the correct cilium-agent
variable enableIdentityMask. Additionally add text in Calico guide for CNI
chaining to use the field.