test: Scrub GKE cluster more thoroughly when releasing cluster.#12192
Merged
test: Scrub GKE cluster more thoroughly when releasing cluster.#12192
Conversation
Member
Author
|
test-gke |
ba0d813 to
8fbda12
Compare
Member
Author
|
test-gke |
Noticed in local testing that an Istio sidecar-injector label can prevent PODs being deployed in the default namespace if left behind by a failed Istio test. Delete also all other resources left into the default namespace. Delete cilium-monitoring and cilium namespaces to leave the cluster in a more predictable condition. Finally, delete all CRDs. Move the cleaning to the renamed `gke/clean-cluster.sh` so that it can be reused from the command line in local testing. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
8fbda12 to
00d964d
Compare
Member
Author
|
test-gke |
Member
Author
|
Note to reviewers and committers: This PR only touches scripts used by CI on GKE, so there is no need to run any other than the GKE CI pipeline. |
aanm
approved these changes
Jun 19, 2020
nebril
approved these changes
Jun 19, 2020
nebril
approved these changes
Jun 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed in local testing that an Istio sidecar-injector label can
prevent PODs being deployed in the default namespace if left behind by
a failed Istio test, so deleted this label in the clean-up.
Delete also all other resources left into the default namespace.
Delete cilium-monitoring and cilium namespaces to leave the cluster in
a more predictable condition and remove all CRDs from the cluster.
Move the cleaning to the renamed
gke/clean-cluster.shso that it can be reused from the command line in local testing.These changes allowed the
cilium-ci-12cluster to successfully pass all the K8s tests, while before it would not pass anything.Fixes: #11928
Signed-off-by: Jarno Rajahalme jarno@covalent.io