Skip to content

operator: sync CiliumNodes into etcd instead of k8s nodes#12179

Merged
aanm merged 2 commits intocilium:masterfrom
aanm:pr/fix-etcd-routes
Jun 18, 2020
Merged

operator: sync CiliumNodes into etcd instead of k8s nodes#12179
aanm merged 2 commits intocilium:masterfrom
aanm:pr/fix-etcd-routes

Conversation

@aanm
Copy link
Copy Markdown
Member

@aanm aanm commented Jun 18, 2020

operator: sync cilium nodes to kvstore instead of k8s nodes

As Cilium is more dependent on the CiliumNodes information to be more up
to date, the Cilium Operator should sync those nodes into the KVStore
instead of the k8s nodes. Using k8s nodes is not reliable as some of the
fields set in these structures are not up to date with the fields set in
the Cilium Nodes.

Signed-off-by: André Martins andre@cilium.io

@maintainer-s-little-helper
Copy link
Copy Markdown

Please set the appropriate release note label.

@aanm
Copy link
Copy Markdown
Member Author

aanm commented Jun 18, 2020

test-focus K8sDatapathConfig

@aanm
Copy link
Copy Markdown
Member Author

aanm commented Jun 18, 2020

test-4.19

aanm added 2 commits June 18, 2020 16:03
Signed-off-by: André Martins <andre@cilium.io>
As Cilium is more dependent on the CiliumNodes information to be more up
to date, the Cilium Operator should sync those nodes into the KVStore
instead of the k8s nodes. Using k8s nodes is not reliable as some of the
fields set in these structures are not up to date with the fields set in
the Cilium Nodes.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/fix-etcd-routes branch from 8b2a29e to 63b5441 Compare June 18, 2020 14:03
@aanm
Copy link
Copy Markdown
Member Author

aanm commented Jun 18, 2020

test-me-please

@aanm aanm changed the title pkg/nodediscovery: print node when registering it into the cluster operator: sync CiliumNodes into etcd instead of k8s nodes Jun 18, 2020
@aanm aanm added kind/bug This is a bug in the Cilium logic. needs-backport/1.8 release-note/bug This PR fixes an issue in a previous release of Cilium. labels Jun 18, 2020
@aanm aanm marked this pull request as ready for review June 18, 2020 14:04
@aanm aanm requested review from a team as code owners June 18, 2020 14:04
@aanm aanm requested a review from a team June 18, 2020 14:04
@aanm aanm requested a review from a team as a code owner June 18, 2020 14:04
@aanm
Copy link
Copy Markdown
Member Author

aanm commented Jun 18, 2020

test-gke wrong tab, ignore

@aanm aanm merged commit 6d44f4c into cilium:master Jun 18, 2020
@aanm aanm deleted the pr/fix-etcd-routes branch June 18, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants