operator: Make CRD availability timeout configurable#12177
operator: Make CRD availability timeout configurable#12177aanm merged 3 commits intocilium:masterfrom
Conversation
|
Please set the appropriate release note label. |
|
test-me-please |
|
Coverage increased (+0.007%) to 37.175% when pulling 0f3f1b8107aeb883d2739030a9ec4fbfe52a5a0e on mrostecki:operator-crd-followup into 783982c on cilium:master. |
9c749cf to
4110b22
Compare
There was a problem hiding this comment.
I think we are almost there. There was another PR with similar changes and I think this is the right steps to add new options into the config map:
#12185 (comment)
There was a problem hiding this comment.
I've done it more similar way to how defaultBpfCtAnyMax variable is handled, since it might contain a custom value, not a true/false bool. Please look if you are fine with that.
joestringer
left a comment
There was a problem hiding this comment.
Minor nit on the docs side to clarify what it means by "CRDs have to be available".
3c925ad to
45e240b
Compare
|
test-me-please |
5702ef6 to
d7d08c6
Compare
|
test-me-please |
d7d08c6 to
a4cedaa
Compare
|
test-me-please |
aanm
left a comment
There was a problem hiding this comment.
Discussed with Michal offline. It's not there yet, mostly due my fault.
a4cedaa to
0f3f1b8
Compare
|
test-me-please |
christarazi
left a comment
There was a problem hiding this comment.
LGTM, just a few nits below
There was a problem hiding this comment.
Nit:
| flags.Duration(operatorOption.CRDWaitTimeout, 5*time.Minute, "Operator will exit if CRDs are not available within this duration from startup") | |
| flags.Duration(operatorOption.CRDWaitTimeout, 5*time.Minute, "Operator will exit if CRDs are not available within this duration upon startup") |
There was a problem hiding this comment.
Nit: s/from/upon; there are many occurrences of this
This change allows to override the default 5m timeout with the --crd-wait-timeout option. Signed-off-by: Michal Rostecki <mrostecki@opensuse.org>
Signed-off-by: Michal Rostecki <mrostecki@opensuse.org>
Signed-off-by: Michal Rostecki <mrostecki@opensuse.org>
0f3f1b8 to
efa8d1f
Compare
|
The CI was previously green, the only changes addressed were typos point it out by Chris. Merging |
This change allows to override the default 5m timeout with the
--crd-wait-timeout option.
Signed-off-by: Michal Rostecki mrostecki@opensuse.org
Follow up to #10899