Skip to content

docs: Add IP fragmentation tracking section#12162

Merged
borkmann merged 2 commits intocilium:masterfrom
joestringer:submit/ip-frag-docs
Jun 19, 2020
Merged

docs: Add IP fragmentation tracking section#12162
borkmann merged 2 commits intocilium:masterfrom
joestringer:submit/ip-frag-docs

Conversation

@joestringer
Copy link
Copy Markdown
Member

Based partially on prior wording from Quentin Monnet.

@joestringer joestringer added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.8 labels Jun 18, 2020
@joestringer joestringer requested a review from qmonnet June 18, 2020 03:42
@joestringer joestringer requested a review from a team as a code owner June 18, 2020 03:42
@joestringer
Copy link
Copy Markdown
Member Author

PTAL, my understanding is that we're auto-enabling this so I'm not sure if we should be calling this "beta". However Quentin had mentioned in other contexts that this feature in conjunction with kube-proxy-free was "experimental" in some sense.

@joestringer joestringer requested a review from tgraf June 18, 2020 03:43
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.001%) to 37.122% when pulling 42248d104b0c2cba4bf0715f25e5c12aadc61828 on joestringer:submit/ip-frag-docs into d2beddb on cilium:master.

Copy link
Copy Markdown
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but i don't know enough to approve :)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe

Suggested change
to allow protocols that do not support segmentation (such as UDP) to
to allow protocols that do not support fragmentation (such as UDP) to

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was deliberate, although they're synonyms I've tended to see segmentation used to talk about breaking up messages into datagrams at layer 4 while people seem to use fragmentation to refer to layer 3 message partitioning. (Reviewers, I'd be interested to hear if you disagree)

Copy link
Copy Markdown
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for that! A few comments below.

Regarding the beta/experimental aspect, this would refer to #11180 (not sure if worth mentioning that in the doc?).

Comment thread Documentation/concepts/networking/fragmentation.rst Outdated
Comment thread Documentation/concepts/networking/fragmentation.rst Outdated
Comment thread Documentation/concepts/networking/fragmentation.rst Outdated
@joestringer joestringer force-pushed the submit/ip-frag-docs branch from 42248d1 to 77a49d4 Compare June 18, 2020 17:13
@joestringer joestringer requested a review from qmonnet June 18, 2020 17:14
Rework a couple of the existing instances to reuse this.

Signed-off-by: Joe Stringer <joe@cilium.io>
Based partially on prior wording from Quentin Monnet.

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer force-pushed the submit/ip-frag-docs branch from 77a49d4 to 4b0b093 Compare June 18, 2020 17:55
Copy link
Copy Markdown
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good, thank you!

@borkmann borkmann merged commit 5d00f6a into cilium:master Jun 19, 2020
@joestringer joestringer deleted the submit/ip-frag-docs branch June 19, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants