cilium/charts: set system-{node,cluster}-critical priorityClass for k8s >= 1.17#12151
Merged
aanm merged 1 commit intocilium:masterfrom Jun 18, 2020
Merged
cilium/charts: set system-{node,cluster}-critical priorityClass for k8s >= 1.17#12151aanm merged 1 commit intocilium:masterfrom
aanm merged 1 commit intocilium:masterfrom
Conversation
Performing a "greater than 16" causes the logic to be true when the cluster is running with a minor version set to "16+" which is incorrect. With this commit, the priorityClass will only be set when the clusters are "greater or equal than 17". Fixes: ce99a99 ("Set priorityClassName outside kube-system in k8s 1.17+") Signed-off-by: André Martins <andre@cilium.io>
tgraf
approved these changes
Jun 17, 2020
rolinh
approved these changes
Jun 17, 2020
Member
Author
|
test-me-please |
joestringer
approved these changes
Jun 18, 2020
michi-covalent
approved these changes
Jun 18, 2020
Member
Author
|
test-missed-k8s |
Member
Author
|
all known flakes merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performing a "greater than 16" causes the logic to be true when the
cluster is running with a minor version set to "16+" which is incorrect.
With this commit, the priorityClass will only be set when the clusters
are "greater or equal than 17".
Fixes: ce99a99 ("Set priorityClassName outside kube-system in k8s 1.17+")
Signed-off-by: André Martins andre@cilium.io