Skip to content

doc: Specify CILIUM_NAMESPACE for Hubble installation instruction#12149

Merged
borkmann merged 1 commit intomasterfrom
pr/michi/namespace
Jun 18, 2020
Merged

doc: Specify CILIUM_NAMESPACE for Hubble installation instruction#12149
borkmann merged 1 commit intomasterfrom
pr/michi/namespace

Conversation

@michi-covalent
Copy link
Copy Markdown
Contributor

@michi-covalent michi-covalent commented Jun 17, 2020

This makes it easier to follow the instructions, especially for GKE which
uses cilium namespace instead of kube-system.

Signed-off-by: Michi Mutsuzaki michi@isovalent.com

@michi-covalent michi-covalent added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. area/hubble labels Jun 17, 2020
@michi-covalent michi-covalent requested a review from a team as a code owner June 17, 2020 19:13
@michi-covalent
Copy link
Copy Markdown
Contributor Author

michi-covalent commented Jun 17, 2020 •
edited
Loading

cc @rolinh this is the best i came up with :(

rolinh
rolinh requested changes Jun 17, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@rolinh rolinh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's the only way without reworking all getting started guides to add a section at the beginning to set some environment variables that are referred to later. LGTM except for the suggested change.

Comment thread Documentation/gettingstarted/namespace-cilium.rst Outdated
Comment thread Documentation/gettingstarted/namespace-kube-system.rst Outdated
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 17, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 37.119% when pulling 8cb7123 on pr/michi/namespace into 62eb008 on master.

@michi-covalent
doc: Specify CILIUM_NAMESPACE for Hubble installation instruction
8cb7123 
This makes it easier to follow the instructions, especially for GKE which
uses cilium namespace instead of kube-system.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@rolinh rolinh mentioned this pull request Jun 17, 2020
Closed
@borkmann borkmann merged commit 575bff8 into master Jun 18, 2020
@borkmann borkmann deleted the pr/michi/namespace branch June 18, 2020 06:41
@jrajahalme jrajahalme mentioned this pull request Jun 18, 2020
Merged
@kaworu kaworu mentioned this pull request Aug 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rolinh rolinh rolinh approved these changes

Assignees

No one assigned

Labels

area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@michi-covalent @coveralls @rolinh @kaworu @borkmann @christarazi @jrajahalme