Skip to content

contrib: Misc. fixups for k8s-cilium-exec.sh script#12126

Merged
aanm merged 2 commits intocilium:masterfrom
christarazi:pr/christarazi/misc-fixups-contrib-script
Jun 17, 2020
Merged

contrib: Misc. fixups for k8s-cilium-exec.sh script#12126
aanm merged 2 commits intocilium:masterfrom
christarazi:pr/christarazi/misc-fixups-contrib-script

Conversation

@christarazi
Copy link
Copy Markdown
Member

@christarazi christarazi commented Jun 17, 2020

See commit msgs.

@christarazi
contrib: Fix passing multiple args to script
4375ada 
This commit makes it possible to do the following:

```
$ ./contrib/k8s/k8s-cilium-exec.sh bash -c "cilum status && hostname && echo"
```

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi
contrib: Fixup k8s-cilium-exec.sh script
d63a1ed 
This commit adds a few misc. changes such as defining a new helper
function and using double-quotes around variables for consistency.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi requested a review from a team as a code owner June 17, 2020 04:59
@christarazi christarazi added the area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. label Jun 17, 2020
@maintainer-s-little-helper
Copy link
Copy Markdown

maintainer-s-little-helper Bot commented Jun 17, 2020

Please set the appropriate release note label.

1 similar comment
@maintainer-s-little-helper
Copy link
Copy Markdown

maintainer-s-little-helper Bot commented Jun 17, 2020

Please set the appropriate release note label.

@christarazi christarazi added kind/cleanup This includes no functional changes. needs-backport/1.7 release-note/misc This PR makes changes that have no direct user impact. labels Jun 17, 2020
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 17, 2020

Coverage Status

Coverage increased (+0.02%) to 37.07% when pulling d63a1ed on christarazi:pr/christarazi/misc-fixups-contrib-script into df97ca1 on cilium:master.

@aanm aanm merged commit 8191855 into cilium:master Jun 17, 2020
@christarazi christarazi deleted the pr/christarazi/misc-fixups-contrib-script branch June 17, 2020 18:27
@jrajahalme jrajahalme mentioned this pull request Jun 18, 2020
Merged
@christarazi christarazi mentioned this pull request Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aanm aanm aanm approved these changes

Assignees

No one assigned

Labels

area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@christarazi @coveralls @aanm @borkmann @joestringer @jrajahalme