Skip to content

add missing hook in misc unit tests#12122

Merged
aanm merged 1 commit intocilium:masterfrom
aanm:pr/fix-unit-tests
Jun 19, 2020
Merged

add missing hook in misc unit tests#12122
aanm merged 1 commit intocilium:masterfrom
aanm:pr/fix-unit-tests

Conversation

@aanm
Copy link
Copy Markdown
Member

@aanm aanm commented Jun 16, 2020

All test packages need to have a hook for check.v1

This commit adds the missing checks on those unit tests.

Signed-off-by: André Martins andre@cilium.io

@aanm aanm added release-note/ci This PR makes changes to the CI. needs-backport/1.8 labels Jun 16, 2020
@aanm aanm requested review from a team as code owners June 16, 2020 21:22
@aanm aanm requested a review from a team June 16, 2020 21:22
@brb
Copy link
Copy Markdown
Member

brb commented Jun 17, 2020

Travis CI failure looks legit:

# github.com/cilium/cilium/pkg/azure/api

vet: pkg/azure/api/api_interaction_test.go:60:60: too few arguments in call to client.GetInstances

Makefile:395: recipe for target 'govet' failed

make[1]: *** [govet] Error 2

make[1]: Leaving directory '/home/travis/gopath/src/github.com/cilium/cilium'

Makefile:217: recipe for target 'unit-tests' failed

make: *** [unit-tests] Error 2

All test packages need to have a hook for check.v1

This commit adds the missing checks on those unit tests.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/fix-unit-tests branch from ce8655a to 3c0cf6b Compare June 17, 2020 09:20
@aanm aanm removed the request for review from a team June 17, 2020 09:20
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) to 37.056% when pulling 3c0cf6b on aanm:pr/fix-unit-tests into 305093a on cilium:master.

@aanm aanm merged commit ff4882a into cilium:master Jun 19, 2020
@aanm aanm deleted the pr/fix-unit-tests branch June 19, 2020 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/ci This PR makes changes to the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants