Skip to content

docs: Improve consistency in Azure docs#12108

Merged
borkmann merged 2 commits intomasterfrom
pr/errordeveloper/azure-guide-improvements
Jun 18, 2020
Merged

docs: Improve consistency in Azure docs#12108
borkmann merged 2 commits intomasterfrom
pr/errordeveloper/azure-guide-improvements

Conversation

@errordeveloper
Copy link
Copy Markdown
Contributor

@errordeveloper errordeveloper commented Jun 16, 2020 •
edited
Loading

  • move az aks create to a separate file
  • remove --generate-ssh-keys
  • ensure each version creates 2-node clusters
  • ensure each version calls az group create
  • avoid asking user copy-paste API credentials,
    utilise exsiting dependency on jq
  • ensure beta marking is present

@errordeveloper errordeveloper added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. area/azure Impacts Azure based IPAM. labels Jun 16, 2020
@errordeveloper errordeveloper requested a review from a team as a code owner June 16, 2020 16:56
@errordeveloper errordeveloper mentioned this pull request Jun 16, 2020
Closed
20 tasks
@errordeveloper errordeveloper force-pushed the pr/errordeveloper/azure-guide-improvements branch from 6a8758b to a7d67da Compare June 16, 2020 17:36
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 16, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 37.039% when pulling 415a861 on pr/errordeveloper/azure-guide-improvements into 8191b16 on master.

@errordeveloper errordeveloper force-pushed the pr/errordeveloper/azure-guide-improvements branch 2 times, most recently from 3e00d39 to 415a861 Compare June 17, 2020 08:11
@errordeveloper errordeveloper mentioned this pull request Jun 17, 2020
Closed
gandro
gandro reviewed Jun 17, 2020
View reviewed changes
Comment thread Documentation/gettingstarted/k8s-install-aks-create-cluster.rst
@joestringer joestringer added the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Jun 17, 2020
@errordeveloper
docs: Improve consistency in Azure docs
1540389 
- move `az aks create` to a separate file
- remove `--generate-ssh-keys` as it's not required
- use long flag names consistently
- ensure each version creates 2-node clusters
- ensure each version calls `az group create`
- avoid asking user copy-paste API credentials,
  utilise exsiting dependency on `jq`

Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
@errordeveloper
docs: Ensure Azure IPAM documentation pages are marked as beta
a0978de 
Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
@errordeveloper errordeveloper force-pushed the pr/errordeveloper/azure-guide-improvements branch from 415a861 to a0978de Compare June 18, 2020 09:58
@borkmann borkmann merged commit cf76e2b into master Jun 18, 2020
@borkmann borkmann deleted the pr/errordeveloper/azure-guide-improvements branch June 18, 2020 10:04
@jrajahalme jrajahalme mentioned this pull request Jun 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gandro gandro gandro left review comments

@joestringer joestringer joestringer approved these changes

@christarazi christarazi christarazi approved these changes

+1 more reviewer

@tgraf tgraf tgraf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gandro gandro

Labels

area/azure Impacts Azure based IPAM. area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@errordeveloper @coveralls @gandro @joestringer @tgraf @christarazi @borkmann