Conversation
This will allow us to read config variables in ginkgo-ext package before ginkgo creates a test tree. Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
Parsing cli flags in init func of our test package caused flag values to be unavailable when ginkgo is creating test tree, which caused `cilium.RunQuarantined` option to always be false. This change moves flag parsing to a moment before ginkgo tree is created. Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
|
Please set the appropriate release note label. |
Member
Author
|
test-me-please |
qmonnet
approved these changes
Jun 16, 2020
Member
qmonnet
left a comment
There was a problem hiding this comment.
Looks good to me.
If I understand correctly, second commit (to parse just -cilium.* flags) is necessary because we'd parse the other arguments passed to ginkgo (like --focus) otherwise?
Member
Author
|
@qmonnet correct, other arguments are parsed by ginkgo and |
aanm
approved these changes
Jun 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review per commit, this change fixes quarantine pipelines.