Skip to content

docs: Add note about --node-ip kubelet option#12095

Merged
borkmann merged 1 commit intomasterfrom
pr/gandro/docs-kubelet-node-ip
Jun 16, 2020
Merged

docs: Add note about --node-ip kubelet option#12095
borkmann merged 1 commit intomasterfrom
pr/gandro/docs-kubelet-node-ip

Conversation

@gandro
Copy link
Copy Markdown
Member

@gandro gandro commented Jun 16, 2020

This adds a note about setting the --node-ip correctly in kube-proxy
free deployments with kubeadm. Without --node-ip set correctly,
Cilium's multi-device detection will not pick up all needed interfaces.

@gandro gandro added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. needs-backport/1.8 labels Jun 16, 2020
@gandro gandro requested a review from a team as a code owner June 16, 2020 11:37
@maintainer-s-little-helper
Copy link
Copy Markdown

maintainer-s-little-helper Bot commented Jun 16, 2020

Please set the appropriate release note label.

3 similar comments
@maintainer-s-little-helper
Copy link
Copy Markdown

maintainer-s-little-helper Bot commented Jun 16, 2020

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link
Copy Markdown

maintainer-s-little-helper Bot commented Jun 16, 2020

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link
Copy Markdown

maintainer-s-little-helper Bot commented Jun 16, 2020

Please set the appropriate release note label.

@gandro
Copy link
Copy Markdown
Member Author

gandro commented Jun 16, 2020

test-docs-please

@gandro gandro added release-note/misc This PR makes changes that have no direct user impact. and removed area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. labels Jun 16, 2020
@gandro gandro mentioned this pull request Jun 16, 2020
Closed
20 tasks
@borkmann
Copy link
Copy Markdown
Member

borkmann commented Jun 16, 2020

Looks good, will merge after #12045 .

brb
brb reviewed Jun 16, 2020
View reviewed changes
Comment thread Documentation/gettingstarted/kubeproxy-free.rst Outdated
@gandro
docs: Add note about --node-ip kubelet option
e6f613c 
This adds a note about setting the `--node-ip` correctly in kube-proxy
free deployments with kubeadm. Without `--node-ip` set correctly,
Cilium's multi-device detection will not pick up all needed interfaces.

Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
@gandro gandro force-pushed the pr/gandro/docs-kubelet-node-ip branch from d83a466 to e6f613c Compare June 16, 2020 12:09
@gandro
Copy link
Copy Markdown
Member Author

gandro commented Jun 16, 2020

test-docs-please

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 16, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 37.047% when pulling e6f613c on pr/gandro/docs-kubelet-node-ip into 00ef71b on master.

@borkmann borkmann merged commit 67281df into master Jun 16, 2020
@borkmann borkmann deleted the pr/gandro/docs-kubelet-node-ip branch June 16, 2020 13:18
@borkmann borkmann mentioned this pull request Jun 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brb brb brb approved these changes

@borkmann borkmann borkmann approved these changes

Assignees

No one assigned

Labels

area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gandro @borkmann @coveralls @brb