Merged
Conversation
Member
Author
|
test-me-please |
pchaigno
approved these changes
Jun 16, 2020
Member
pchaigno
left a comment
There was a problem hiding this comment.
One nit below. LGTM otherwise!
Thanks for fixing this Jarno! 🎉 It was really confusing when I started.
tklauser
approved these changes
Jun 16, 2020
Member
tklauser
left a comment
There was a problem hiding this comment.
Some small nits, otherwise LGTM.
qmonnet
approved these changes
Jun 16, 2020
Member
|
Looks good, I would apply changes suggested by @tklauser though. |
Ginkgo --focus option is a regular expression that matches a substring without any trailing wildcarding. Simplify all --focus parameters accordingly. The --focus parameter is also not repeatable, the last one takes the effect if multiple ones are given. Fix the docs for this. Update the document to the current default K8S_VERSION (1.18). Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
464905b to
e295283
Compare
Member
Author
|
test-me-please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ginkgo --focus option is a regular expression that matches a substring
without any trailing wildcarding. Simplify all --focus parameters
accordingly. The --focus parameter is also not repeatable, the last
one takes the effect if multiple ones are given. Fix the docs for
this.
Update the document to the current default K8S_VERSION (1.18).
Signed-off-by: Jarno Rajahalme jarno@covalent.io