Skip to content

doc: Misc fixups for Transparent Encryption GSG#12088

Merged
borkmann merged 2 commits intocilium:masterfrom
christarazi:pr/christarazi/misc-fixups-enc-docs
Jun 16, 2020
Merged

doc: Misc fixups for Transparent Encryption GSG#12088
borkmann merged 2 commits intocilium:masterfrom
christarazi:pr/christarazi/misc-fixups-enc-docs

Conversation

@christarazi
Copy link
Copy Markdown
Member

@christarazi christarazi commented Jun 16, 2020

Updates #11903

@christarazi christarazi requested a review from a team as a code owner June 16, 2020 00:06
@maintainer-s-little-helper
Copy link
Copy Markdown

maintainer-s-little-helper Bot commented Jun 16, 2020

Please set the appropriate release note label.

@christarazi christarazi added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label Jun 16, 2020
@maintainer-s-little-helper
Copy link
Copy Markdown

maintainer-s-little-helper Bot commented Jun 16, 2020

Please set the appropriate release note label.

@christarazi christarazi requested a review from jrfastab June 16, 2020 00:06
@maintainer-s-little-helper
Copy link
Copy Markdown

maintainer-s-little-helper Bot commented Jun 16, 2020

Please set the appropriate release note label.

2 similar comments
@maintainer-s-little-helper
Copy link
Copy Markdown

maintainer-s-little-helper Bot commented Jun 16, 2020

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link
Copy Markdown

maintainer-s-little-helper Bot commented Jun 16, 2020

Please set the appropriate release note label.

@christarazi christarazi added the release-note/misc This PR makes changes that have no direct user impact. label Jun 16, 2020
@christarazi
Copy link
Copy Markdown
Member Author

christarazi commented Jun 16, 2020

test-docs-please

@christarazi christarazi force-pushed the pr/christarazi/misc-fixups-enc-docs branch 2 times, most recently from df766e5 to 7b9f618 Compare June 16, 2020 00:28
@b3a-dev b3a-dev mentioned this pull request Jun 16, 2020
Closed
20 tasks
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 16, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.05%) to 37.023% when pulling 2d0a508 on christarazi:pr/christarazi/misc-fixups-enc-docs into 331aab4 on cilium:master.

pchaigno
pchaigno approved these changes Jun 16, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit below; 👍 otherwise!

(Finally, a native speaker who uses commas 🎉 That really helps to quickly parse sentences, not being a native speaker.)

Comment thread Documentation/gettingstarted/encryption.rst Outdated
@maintainer-s-little-helper
Copy link
Copy Markdown

maintainer-s-little-helper Bot commented Jun 16, 2020

Commit 592df99ad890b172d273421f9b4f6b6fa3b6454a does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper Bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jun 16, 2020
@christarazi
doc: Add misc. improvements to encryption guide
9545f6f 
Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi
doc: Add note not encrypting within the node
2d0a508 
Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi force-pushed the pr/christarazi/misc-fixups-enc-docs branch from 592df99 to 2d0a508 Compare June 16, 2020 16:32
@maintainer-s-little-helper maintainer-s-little-helper Bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jun 16, 2020
@christarazi
Copy link
Copy Markdown
Member Author

christarazi commented Jun 16, 2020

Travis hit #12111

jrfastab
jrfastab reviewed Jun 16, 2020
View reviewed changes
Comment thread Documentation/gettingstarted/encryption.rst
--set global.tunnel=vxlan \
--set global.encryption.enabled=true \
--set global.encryption.nodeEncryption=false

Copy link
Copy Markdown
Contributor

@jrfastab jrfastab Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its probably preferred to run GKE with direct routing but having an example is nice. We can add a direct routing example later.

Copy link
Copy Markdown
Member

@borkmann borkmann Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we still add one as follow-up, so we don't loose track of it? Thx

@borkmann borkmann merged commit dc4f549 into cilium:master Jun 16, 2020
@christarazi christarazi deleted the pr/christarazi/misc-fixups-enc-docs branch June 17, 2020 00:28
@christarazi christarazi mentioned this pull request Jun 17, 2020
Closed
@jrajahalme jrajahalme mentioned this pull request Jun 18, 2020
Merged
@christarazi christarazi mentioned this pull request Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@borkmann borkmann borkmann left review comments

@jrfastab jrfastab jrfastab approved these changes

@pchaigno pchaigno pchaigno approved these changes

Assignees

No one assigned

Labels

area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@christarazi @coveralls @borkmann @jrfastab @pchaigno @joestringer @jrajahalme