test: Fix hubble-relay image helm path#12076
Merged
joestringer merged 1 commit intomasterfrom Jun 16, 2020
Merged
Conversation
'hubble-relay.image' was changed from a string to a map of strings by commit commit bbf5377 ("Fix values scoping for newly implemented sub-chart hubble-relay"). Fix the test helpers accordingly. Without this helm would panic when ginkgo option '-cilium.hubble-relay-image="docker.io/cilium/hubble-relay:latest"' is passed as the helm command line included both 'hubble-relay.image' and 'hubble-relay.image.tag' like so: $ helm template install/kubernetes/cilium --namespace=cilium --set hubble-relay.image=docker.io/cilium/hubble-relay:latest --set hubble-relay.image.tag=latest panic: interface conversion: interface {} is string, not map[string]interface {} goroutine 1 [running]: helm.sh/helm/v3/pkg/strvals.(*parser).key(0xc0004c5ac0, 0xc00031a3c0, 0xc00067f800, 0xc) /private/tmp/helm-20200608-50972-gq0j1j/src/helm.sh/helm/pkg/strvals/parser.go:211 +0xdea Fixes: bbf5377 Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
Member
Author
|
test-me-please |
michi-covalent
approved these changes
Jun 15, 2020
joestringer
approved these changes
Jun 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'hubble-relay.image' was changed from a string to a map of strings by
commit commit bbf5377 ("Fix values scoping for newly implemented
sub-chart hubble-relay"). Fix the test helpers accordingly.
Without this helm would panic when ginkgo option
'-cilium.hubble-relay-image="docker.io/cilium/hubble-relay:latest"' is
passed as the helm command line included both 'hubble-relay.image' and
'hubble-relay.image.tag' like so:
$ helm template install/kubernetes/cilium --namespace=cilium --set hubble-relay.image=docker.io/cilium/hubble-relay:latest --set hubble-relay.image.tag=latest
panic: interface conversion: interface {} is string, not map[string]interface {}
goroutine 1 [running]:
helm.sh/helm/v3/pkg/strvals.(*parser).key(0xc0004c5ac0, 0xc00031a3c0, 0xc00067f800, 0xc)
/private/tmp/helm-20200608-50972-gq0j1j/src/helm.sh/helm/pkg/strvals/parser.go:211 +0xdea
Fixes: #11757
Signed-off-by: Jarno Rajahalme jarno@covalent.io