helm: Clean up the hubble-relay DNS name in the UI chart#12033
Merged
Conversation
rolinh
approved these changes
Jun 12, 2020
Member
|
test-me-please |
gandro
approved these changes
Jun 15, 2020
gandro
requested changes
Jun 15, 2020
Member
gandro
left a comment
There was a problem hiding this comment.
I approved a bit too early, can you also remove the corresponding value, since it is now unused?
nebril
reviewed
Jun 15, 2020
Member
nebril
left a comment
There was a problem hiding this comment.
Same comment as Sebastian, LGTM otherwise.
Specifying the service name by itself as the DNS is sufficient since hubble-relay and hubble-ui get deployed to the same namespace. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
d8f9355 to
41c5a0a
Compare
aanm
reviewed
Jun 17, 2020
Member
|
test-me-please |
gandro
approved these changes
Jun 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifying the service name by itself as the DNS is sufficient since
hubble-relay and hubble-ui get deployed to the same namespace.
Signed-off-by: Michi Mutsuzaki michi@isovalent.com