Skip to content

test: don't check destination label in RuntimePolicies with PolicyAuditMode#12003

Merged
nebril merged 1 commit intomasterfrom
pr/tklauser/runtime-policies-wait-endpoint-identity
Jun 10, 2020
Merged

test: don't check destination label in RuntimePolicies with PolicyAuditMode#12003
nebril merged 1 commit intomasterfrom
pr/tklauser/runtime-policies-wait-endpoint-identity

Conversation

@tklauser
Copy link
Copy Markdown
Member

It might rarely happen that the host starts pinging fast enough that
the endpoint still has identity "init" / 5. This currently leads to fail
the test.

As already done in the egress case, ignore the destination labels when
checking the hubble observe output.

Fixes #11954

@tklauser tklauser added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. ci/flake This is a known failure that occurs in the tree. Please investigate me! labels Jun 10, 2020
@tklauser
Copy link
Copy Markdown
Member Author

test-focus RuntimePolicies

Copy link
Copy Markdown
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Comment thread test/runtime/Policies.go Outdated
@tklauser tklauser force-pushed the pr/tklauser/runtime-policies-wait-endpoint-identity branch from c3e2d41 to 8fecc32 Compare June 10, 2020 12:15
…itMode

It might rarely happen that the host starts pinging fast enough that
the endpoint still has identity "init" / 5. This currently leads to fail
the test.

As already done in the egress case, ignore the destination labels when
checking the hubble observe output.

Fixes #11954

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser force-pushed the pr/tklauser/runtime-policies-wait-endpoint-identity branch from 8fecc32 to a63a19a Compare June 10, 2020 12:19
@tklauser tklauser marked this pull request as ready for review June 10, 2020 12:19
@tklauser tklauser requested a review from a team as a code owner June 10, 2020 12:19
@tklauser
Copy link
Copy Markdown
Member Author

test-me-please

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 10, 2020

Coverage Status

Coverage increased (+0.02%) to 37.06% when pulling a63a19a on pr/tklauser/runtime-policies-wait-endpoint-identity into 1319eff on master.

@tklauser
Copy link
Copy Markdown
Member Author

tklauser commented Jun 10, 2020

retest-runtime (previous failure: https://jenkins.cilium.io/job/Cilium-PR-Runtime-4.9/723)

@maintainer-s-little-helper maintainer-s-little-helper Bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 10, 2020
@nebril nebril merged commit 027ea95 into master Jun 10, 2020
@nebril nebril deleted the pr/tklauser/runtime-policies-wait-endpoint-identity branch June 10, 2020 16:26
@aanm aanm mentioned this pull request Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/CI Continuous Integration testing issue or flake ci/flake This is a known failure that occurs in the tree. Please investigate me! ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: RuntimePolicies: Init Policy Default Drop Test With PolicyAuditMode tests ingress

8 participants