Merged
Conversation
20 tasks
pchaigno
approved these changes
Jun 8, 2020
tklauser
approved these changes
Jun 8, 2020
michi-covalent
approved these changes
Jun 8, 2020
This commit fixes the GKE install guide: - `gcloud` now requires to pass `--zone` or `--region` or fails. Update the guide to use `--zone` to all `gcloud` commands that require it. - The set of pods in the `cilium` namespace is different now. Update the sample list so that the reader does not get confused. - Add `=true` to `--set nodeinit.restartPods` as without specifying `=true`, the Helm command fails. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
0bc8856 to
383ff09
Compare
tklauser
approved these changes
Jun 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the GKE install guide:
gcloudnow requires to pass--zoneor--regionor fails. Updatethe guide to use
--zoneto allgcloudcommands that require it.ciliumnamespace is different now. Update thesample list so that the reader does not get confused.
=trueto--set nodeinit.restartPodsas without specifying=true, the Helm command fails.