service: Clean up HealthCheckNodePort server when traffic policy changes #11952
Merged
service: Clean up HealthCheckNodePort server when traffic policy changes #11952
Conversation
Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
This commit fixes a case where the HealthCheckNodePort service was not removed properly anymore when a LoadBalancer service was changed from externalTrafficPolicy=Local to externalTrafficPolicy=Cluster. The unit tests are extended to capture this behavior. Fixes: f7b0378 ("service: Fix wrong localEndpoints count in HealthCheckNodePort") Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
Member
Author
|
test-me-please |
brb
reviewed
Jun 8, 2020
brb
approved these changes
Jun 8, 2020
borkmann
approved these changes
Jun 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a case where the
HealthCheckNodePortservice was notremoved properly anymore when a
LoadBalancerservice defintion was changed fromexternalTrafficPolicy=LocaltoexternalTrafficPolicy=Cluster. The unittests are extended to capture this behavior.
Fixes: f7b0378 ("service: Fix wrong localEndpoints count in HealthCheckNodePort")