Skip to content

daemon: cancel daemon context on TearDownTest#11870

Merged
borkmann merged 1 commit intomasterfrom
pr/cancel-daemon-ctx
Jun 3, 2020
Merged

daemon: cancel daemon context on TearDownTest#11870
borkmann merged 1 commit intomasterfrom
pr/cancel-daemon-ctx

Conversation

@aanm
Copy link
Copy Markdown
Member

@aanm aanm commented Jun 3, 2020

Signed-off-by: André Martins andre@cilium.io

Fixes:

WARNING: DATA RACE
Read at 0x00c000e98510 by goroutine 167:
  github.com/cilium/cilium/daemon/cmd.(*Daemon).bootstrapFQDN.func1()
      /home/aanm/git-repos/go/src/github.com/cilium/cilium/daemon/cmd/fqdn.go:191 +0x23a
  github.com/cilium/cilium/pkg/controller.(*Controller).runController()
      /home/aanm/git-repos/go/src/github.com/cilium/cilium/pkg/controller/controller.go:205 +0x994
Previous write at 0x00c000e98510 by goroutine 65:
  github.com/cilium/cilium/daemon/cmd.(*DaemonSuite).SetUpTest()
      /home/aanm/git-repos/go/src/github.com/cilium/cilium/daemon/cmd/daemon_test.go:126 +0x479
  github.com/cilium/cilium/daemon/cmd.(*DaemonEtcdSuite).SetUpTest()
      /home/aanm/git-repos/go/src/github.com/cilium/cilium/daemon/cmd/daemon_test.go:167 +0x44
  runtime.call32()
      /home/travis/.gimme/versions/go1.14.4.linux.amd64/src/runtime/asm_amd64.s:539 +0x3a
  reflect.Value.Call()
      /home/travis/.gimme/versions/go1.14.4.linux.amd64/src/reflect/value.go:321 +0xd3
  gopkg.in/check%2ev1.(*suiteRunner).runFixture.func1()
      /home/aanm/git-repos/go/src/github.com/cilium/cilium/vendor/gopkg.in/check.v1/check.go:730 +0x1c3
  gopkg.in/check%2ev1.(*suiteRunner).forkCall.func1()
      /home/aanm/git-repos/go/src/github.com/cilium/cilium/vendor/gopkg.in/check.v1/check.go:675 +0xd9
Goroutine 167 (running) created at:
  github.com/cilium/cilium/pkg/controller.(*Manager).updateController()
      /home/aanm/git-repos/go/src/github.com/cilium/cilium/pkg/controller/manager.go:120 +0xae0
  github.com/cilium/cilium/pkg/controller.(*Manager).UpdateController()
      /home/aanm/git-repos/go/src/github.com/cilium/cilium/pkg/controller/manager.go:59 +0xe4
  github.com/cilium/cilium/daemon/cmd.(*Daemon).bootstrapFQDN()
      /home/aanm/git-repos/go/src/github.com/cilium/cilium/daemon/cmd/fqdn.go:172 +0x815
  github.com/cilium/cilium/daemon/cmd.NewDaemon()
      /home/aanm/git-repos/go/src/github.com/cilium/cilium/daemon/cmd/daemon.go:544 +0x2fcd
  github.com/cilium/cilium/daemon/cmd.(*DaemonSuite).SetUpTest()
      /home/aanm/git-repos/go/src/github.com/cilium/cilium/daemon/cmd/daemon_test.go:115 +0x115
  github.com/cilium/cilium/daemon/cmd.(*DaemonEtcdSuite).SetUpTest()
      /home/aanm/git-repos/go/src/github.com/cilium/cilium/daemon/cmd/daemon_test.go:167 +0x44
  runtime.call32()
      /home/travis/.gimme/versions/go1.14.4.linux.amd64/src/runtime/asm_amd64.s:539 +0x3a
  reflect.Value.Call()
      /home/travis/.gimme/versions/go1.14.4.linux.amd64/src/reflect/value.go:321 +0xd3
  gopkg.in/check%2ev1.(*suiteRunner).runFixture.func1()
      /home/aanm/git-repos/go/src/github.com/cilium/cilium/vendor/gopkg.in/check.v1/check.go:730 +0x1c3
  gopkg.in/check%2ev1.(*suiteRunner).forkCall.func1()
      /home/aanm/git-repos/go/src/github.com/cilium/cilium/vendor/gopkg.in/check.v1/check.go:675 +0xd9
Goroutine 65 (finished) created at:
  gopkg.in/check%2ev1.(*suiteRunner).forkCall()
      /home/aanm/git-repos/go/src/github.com/cilium/cilium/vendor/gopkg.in/check.v1/check.go:672 +0x44d
  gopkg.in/check%2ev1.(*suiteRunner).runFunc()
      /home/aanm/git-repos/go/src/github.com/cilium/cilium/vendor/gopkg.in/check.v1/check.go:682 +0x83
  gopkg.in/check%2ev1.(*suiteRunner).runFixture()
      /home/aanm/git-repos/go/src/github.com/cilium/cilium/vendor/gopkg.in/check.v1/check.go:726 +0x3d
  gopkg.in/check%2ev1.(*suiteRunner).runFixtureWithPanic()
      /home/aanm/git-repos/go/src/github.com/cilium/cilium/vendor/gopkg.in/check.v1/check.go:744 +0x82
  gopkg.in/check%2ev1.(*suiteRunner).forkTest.func1()
      /home/aanm/git-repos/go/src/github.com/cilium/cilium/vendor/gopkg.in/check.v1/check.go:769 +0x28c
  gopkg.in/check%2ev1.(*suiteRunner).forkCall.func1()
      /home/aanm/git-repos/go/src/github.com/cilium/cilium/vendor/gopkg.in/check.v1/check.go:675 +0xd9a
      
      WARNING: DATA RACE
Read at 0x00c000ec82b0 by goroutine 167:
  github.com/cilium/cilium/pkg/endpointmanager.(*EndpointManager).GetEndpoints()
      /home/travis/gopath/src/github.com/cilium/cilium/pkg/endpointmanager/manager.go:428 +0x87
  github.com/cilium/cilium/daemon/cmd.(*Daemon).bootstrapFQDN.func1()
      /home/travis/gopath/src/github.com/cilium/cilium/daemon/cmd/fqdn.go:191 +0x252
  github.com/cilium/cilium/pkg/controller.(*Controller).runController()
      /home/travis/gopath/src/github.com/cilium/cilium/pkg/controller/controller.go:205 +0x994
Previous write at 0x00c000ec82b0 by goroutine 65:
  github.com/cilium/cilium/pkg/endpointmanager.NewEndpointManager()
      /home/travis/gopath/src/github.com/cilium/cilium/pkg/endpointmanager/manager.go:75 +0xd9
  github.com/cilium/cilium/daemon/cmd.(*DaemonSuite).SetUpTest()
      /home/travis/gopath/src/github.com/cilium/cilium/daemon/cmd/daemon_test.go:126 +0x42e
  github.com/cilium/cilium/daemon/cmd.(*DaemonEtcdSuite).SetUpTest()
      /home/travis/gopath/src/github.com/cilium/cilium/daemon/cmd/daemon_test.go:167 +0x44
  runtime.call32()
      /home/travis/.gimme/versions/go1.14.4.linux.amd64/src/runtime/asm_amd64.s:539 +0x3a
  reflect.Value.Call()
      /home/travis/.gimme/versions/go1.14.4.linux.amd64/src/reflect/value.go:321 +0xd3
  gopkg.in/check%2ev1.(*suiteRunner).runFixture.func1()
      /home/travis/gopath/src/github.com/cilium/cilium/vendor/gopkg.in/check.v1/check.go:730 +0x1c3
  gopkg.in/check%2ev1.(*suiteRunner).forkCall.func1()
      /home/travis/gopath/src/github.com/cilium/cilium/vendor/gopkg.in/check.v1/check.go:675 +0xd9
Goroutine 167 (running) created at:
  github.com/cilium/cilium/pkg/controller.(*Manager).updateController()
      /home/travis/gopath/src/github.com/cilium/cilium/pkg/controller/manager.go:120 +0xae0
  github.com/cilium/cilium/pkg/controller.(*Manager).UpdateController()
      /home/travis/gopath/src/github.com/cilium/cilium/pkg/controller/manager.go:59 +0xe4
  github.com/cilium/cilium/daemon/cmd.(*Daemon).bootstrapFQDN()
      /home/travis/gopath/src/github.com/cilium/cilium/daemon/cmd/fqdn.go:172 +0x815
  github.com/cilium/cilium/daemon/cmd.NewDaemon()
      /home/travis/gopath/src/github.com/cilium/cilium/daemon/cmd/daemon.go:544 +0x2fcd
  github.com/cilium/cilium/daemon/cmd.(*DaemonSuite).SetUpTest()
      /home/travis/gopath/src/github.com/cilium/cilium/daemon/cmd/daemon_test.go:115 +0x115
  github.com/cilium/cilium/daemon/cmd.(*DaemonEtcdSuite).SetUpTest()
      /home/travis/gopath/src/github.com/cilium/cilium/daemon/cmd/daemon_test.go:167 +0x44
  runtime.call32()
      /home/travis/.gimme/versions/go1.14.4.linux.amd64/src/runtime/asm_amd64.s:539 +0x3a
  reflect.Value.Call()
      /home/travis/.gimme/versions/go1.14.4.linux.amd64/src/reflect/value.go:321 +0xd3
  gopkg.in/check%2ev1.(*suiteRunner).runFixture.func1()
      /home/travis/gopath/src/github.com/cilium/cilium/vendor/gopkg.in/check.v1/check.go:730 +0x1c3
  gopkg.in/check%2ev1.(*suiteRunner).forkCall.func1()
      /home/travis/gopath/src/github.com/cilium/cilium/vendor/gopkg.in/check.v1/check.go:675 +0xd9
Goroutine 65 (finished) created at:
  gopkg.in/check%2ev1.(*suiteRunner).forkCall()
      /home/travis/gopath/src/github.com/cilium/cilium/vendor/gopkg.in/check.v1/check.go:672 +0x44d
  gopkg.in/check%2ev1.(*suiteRunner).runFunc()
      /home/travis/gopath/src/github.com/cilium/cilium/vendor/gopkg.in/check.v1/check.go:682 +0x83
  gopkg.in/check%2ev1.(*suiteRunner).runFixture()
      /home/travis/gopath/src/github.com/cilium/cilium/vendor/gopkg.in/check.v1/check.go:726 +0x3d
  gopkg.in/check%2ev1.(*suiteRunner).runFixtureWithPanic()
      /home/travis/gopath/src/github.com/cilium/cilium/vendor/gopkg.in/check.v1/check.go:744 +0x82
  gopkg.in/check%2ev1.(*suiteRunner).forkTest.func1()
      /home/travis/gopath/src/github.com/cilium/cilium/vendor/gopkg.in/check.v1/check.go:769 +0x28c
  gopkg.in/check%2ev1.(*suiteRunner).forkCall.func1()
      /home/travis/gopath/src/github.com/cilium/cilium/vendor/gopkg.in/check.v1/check.go:675 +0xd9
==================

@aanm
daemon: cancel daemon context on TearDownTest
abadcf0 
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added release-note/ci This PR makes changes to the CI. needs-backport/1.8 labels Jun 3, 2020
@aanm aanm requested a review from a team June 3, 2020 17:48
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 3, 2020

Coverage Status

Coverage decreased (-0.01%) to 36.937% when pulling abadcf0 on pr/cancel-daemon-ctx into 507d9b8 on master.

@aanm aanm added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 3, 2020
@borkmann borkmann merged commit 56b48e0 into master Jun 3, 2020
@borkmann borkmann deleted the pr/cancel-daemon-ctx branch June 3, 2020 20:15
@tklauser tklauser mentioned this pull request Jun 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tklauser tklauser tklauser approved these changes

+1 more reviewer

@vadorovsky vadorovsky vadorovsky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aanm @coveralls @tklauser @vadorovsky @borkmann