Skip to content

Docs: update backport commands for jenkins builds#11860

Merged
joestringer merged 1 commit intomasterfrom
pr/doc-test-backport
Jun 3, 2020
Merged

Docs: update backport commands for jenkins builds#11860
joestringer merged 1 commit intomasterfrom
pr/doc-test-backport

Conversation

@nebril
Copy link
Copy Markdown
Member

@nebril nebril commented Jun 3, 2020

No description provided.

@nebril nebril requested review from a team as code owners June 3, 2020 12:36
@maintainer-s-little-helper
Copy link
Copy Markdown

Commit 665b72a930b09a10c2f5047189dd5b127f2ac127 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper
Copy link
Copy Markdown

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper Bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jun 3, 2020
@maintainer-s-little-helper
Copy link
Copy Markdown

Please set the appropriate release note label.

@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jun 3, 2020

test-backport-1.6

@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jun 3, 2020

test-backport-1.7

@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jun 3, 2020

test-backport-1.8

@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jun 3, 2020

seems like new commands are working as intended

@nebril nebril force-pushed the pr/doc-test-backport branch from 665b72a to 128dcf2 Compare June 3, 2020 12:41
@maintainer-s-little-helper maintainer-s-little-helper Bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jun 3, 2020
@nebril nebril added the release-note/ci This PR makes changes to the CI. label Jun 3, 2020
Comment thread Documentation/contributing/release/backports.rst Outdated
Copy link
Copy Markdown
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Should we change it in Documentation/contributing/testing/ci.rst (line 239ff):

For Backport PRs, the phrase ``never-tell-me-the-odds`` should be used to
trigger all of the above jobs which are marked as required to validate changes
to existing releases.

was well? Sorry, cannot link to the raw file line directly 😕

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 3, 2020

Coverage Status

Coverage increased (+0.01%) to 36.926% when pulling 4e226e8 on pr/doc-test-backport into bdf98cb on master.

Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril nebril force-pushed the pr/doc-test-backport branch from 128dcf2 to 4e226e8 Compare June 3, 2020 15:42
@nebril
Copy link
Copy Markdown
Member Author

nebril commented Jun 3, 2020

@tklauser thanks, fixed that too!

Copy link
Copy Markdown
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added change in ci.rst also LGTM, thanks!

@aanm aanm added needs-backport/1.8 ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Jun 3, 2020
@joestringer joestringer merged commit 78d99a5 into master Jun 3, 2020
@joestringer joestringer deleted the pr/doc-test-backport branch June 3, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants