k8s: Fix data race when setting node address#11851
Merged
Conversation
The k8s cache handlers will depend on node addressing information so the retrieval of own node information must complete before caches are being synchronized. Also re-add a bootstrap start sequence that was removed accidentally by 05163ed. Fixes: 05163ed ("endpoint: Ensure restored endpoint is validated before regenerating it") Fixes: #11836 Signed-off-by: Thomas Graf <thomas@cilium.io>
Contributor
Author
|
test-me-please |
aanm
approved these changes
Jun 3, 2020
Member
aanm
left a comment
There was a problem hiding this comment.
I've ran a CI with the race detector and it seems the issue was fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The k8s cache handlers will depend on node addressing information so the
retrieval of own node information must complete before caches are being
synchronized.
Also re-add a bootstrap start sequence that was removed accidentally by
05163ed.
Fixes: 05163ed ("endpoint: Ensure restored endpoint is validated before regenerating it")
Fixes: #11836