Add audit action to the policy verdict log#11843
Merged
aanm merged 1 commit intocilium:masterfrom Jun 4, 2020
Merged
Conversation
|
Please set the appropriate release note label. |
1b6c730 to
dcf892b
Compare
Member
|
test-me-please |
joestringer
approved these changes
Jun 3, 2020
Member
joestringer
left a comment
There was a problem hiding this comment.
Minor spelling nit but otherwise LGTM.
I suspect we might be able to hide the POLICY_AUDIT_MODE check inside the policy_can_xxx() functions by passing in &audited but it's probably a little more explicit the current way.
tklauser
approved these changes
Jun 3, 2020
pchaigno
requested changes
Jun 3, 2020
aanm
approved these changes
Jun 3, 2020
The audit mode may overwrite policy related verdict and in this situation it's unclear from the policy verdict log that this happened. This commit adds a new audit bit to the policy log's struct and adds a new policy log action 'audit' based on that flag. Related policy log calls were updated to contain audit flag. Signed-off-by: Arthur Evstifeev <aevstifeev@gitlab.com>
dcf892b to
0f8abe0
Compare
Member
|
retest-4.19 EDIT: Success: https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Kernel/1898/ |
joestringer
approved these changes
Jun 4, 2020
Member
|
retest-runtime |
Member
|
retest-net-next |
Member
|
retest-4.9 |
aanm
approved these changes
Jun 4, 2020
pchaigno
approved these changes
Jun 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The audit mode may overwrite policy related verdict and in this
situation it's unclear from the policy verdict log that this
happened. This commit adds a new audit bit to the policy log's struct
and adds a new policy log action 'audit' based on that flag. Related
policy log calls were updated to contain audit flag.
fixes #11778