Fix live preview with Python 3.8#11838
Merged
joestringer merged 2 commits intocilium:masterfrom Jun 3, 2020
Merged
Conversation
Member
joestringer
commented
Jun 2, 2020
- Fix live preview with python 3.8 (Ubuntu 20.04)
- Sort requirements alphabetically
Signed-off-by: Joe Stringer <joe@cilium.io>
Ubuntu 20.04 ships Python 3.8 by default, which causes `make live-preview` failure during one of the dependency installations in the pipenv unless we bump the "six" version. While we're at it, sort alphabetically. Signed-off-by: Joe Stringer <joe@cilium.io>
michi-covalent
approved these changes
Jun 2, 2020
vadorovsky
approved these changes
Jun 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.