pkg/ipcache: create a GetK8sMetadata for public access#11833
Merged
Conversation
michi-covalent
approved these changes
Jun 2, 2020
Contributor
michi-covalent
left a comment
There was a problem hiding this comment.
ah good to know. thank you for the fix
joestringer
requested changes
Jun 2, 2020
Member
joestringer
left a comment
There was a problem hiding this comment.
Makes sense, one concern below.
0877a6b to
e3ca0cb
Compare
Member
Author
|
test-me-please |
joestringer
approved these changes
Jun 2, 2020
GetK8sMetadata was supposed to be used for internal usage of the package, making this function public requires protection against parallel access by its internal mutex. Fixes: 4699840 ("ipcache: Export GetK8sMetadata") Signed-off-by: André Martins <andre@cilium.io>
e3ca0cb to
de1e490
Compare
Member
Author
|
test-me-please |
Member
Author
|
hit #11847 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetK8sMetadata was supposed to be used for internal usage of the
package, making this function public requires protection against
parallel access by its internal mutex.
Fixes: 4699840 ("ipcache: Export GetK8sMetadata")
Signed-off-by: André Martins andre@cilium.io
Fixes #11832