Conversation
|
test-docs-please |
michi-covalent
left a comment
There was a problem hiding this comment.
looks great one minor nit
c8d69d3 to
75f588f
Compare
|
test-docs-please |
There was a problem hiding this comment.
Should we document using hubble relay even if it's in beta? Because I feel that if we mention this but don't explain how, it's going to be an open question for whoever reads this doc. I would suggest to either remove this note or write doc about how to troubleshoot with hubble relay.
There was a problem hiding this comment.
👍 When I read In order to observe the traffic of a specific pod, you will first have to retrieve the name of the cilium instance managing it, I immediately thought "Why can't I use Hubble relay". (But I've been coached by Robin :p)
Nit if we keep this note: Beta -> beta.
There was a problem hiding this comment.
I discussed this offline with @gandro and I'll add a hubble relay section to the doc.
There was a problem hiding this comment.
I have changed Beta -> beta, but left the note in. My thinking is that we add a link to the hubble-relay section there, but I'm also happy to remove the note completely for now.
There was a problem hiding this comment.
My thinking is that we add a link to the hubble-relay section there
I'll do this as part of writing the hubble relay section.
pchaigno
left a comment
There was a problem hiding this comment.
LGTM except for one/two nits below. Probably not worth fixing if you don't change anything else.
There was a problem hiding this comment.
👍 When I read In order to observe the traffic of a specific pod, you will first have to retrieve the name of the cilium instance managing it, I immediately thought "Why can't I use Hubble relay". (But I've been coached by Robin :p)
Nit if we keep this note: Beta -> beta.
This adds a Hubble section to the Troubleshooting chapter, explaining how to use the CLI for embedded Hubble. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
75f588f to
c424915
Compare
|
test-docs-please |
This adds a Hubble section to the Troubleshooting chapter, explaining how to use the CLI for embedded Hubble.