Skip to content

test: Fix and re-enable test reliant on managed etcd#11818

Merged
tgraf merged 1 commit intomasterfrom
pr/errordeveloper/fix-11690
Jun 2, 2020
Merged

test: Fix and re-enable test reliant on managed etcd#11818
tgraf merged 1 commit intomasterfrom
pr/errordeveloper/fix-11690

Conversation

@errordeveloper
Copy link
Copy Markdown
Contributor

@errordeveloper errordeveloper commented Jun 2, 2020

  • ensure global.identityAllocationMode=kvstore is set; the default
    is crd which is not what etcd test was meant to be testing
  • it looks like there is still a deadlock occuring when default crd
    modes is used

Fixes: #11690

@errordeveloper
test: Fix and re-enable test reliant on managed etcd
a8b2c14 
- ensure `global.identityAllocationMode=kvstore` is set; the default
  is `crd` which is not what etcd test was meant to be testing
- it looks like there is still a deadlock occuring when default `crd`
  modes is used

Fixes: #11690

Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
@errordeveloper errordeveloper requested review from pchaigno and tgraf June 2, 2020 11:03
@errordeveloper errordeveloper requested a review from a team as a code owner June 2, 2020 11:03
@maintainer-s-little-helper
Copy link
Copy Markdown

maintainer-s-little-helper Bot commented Jun 2, 2020

Please set the appropriate release note label.

@errordeveloper
Copy link
Copy Markdown
Contributor Author

errordeveloper commented Jun 2, 2020

test-me-please

@errordeveloper errordeveloper added the release-note/ci This PR makes changes to the CI. label Jun 2, 2020
@pchaigno pchaigno added needs-backport/1.8 ci/flake This is a known failure that occurs in the tree. Please investigate me! labels Jun 2, 2020
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 2, 2020

Coverage Status

Coverage decreased (-0.04%) to 36.889% when pulling a8b2c14 on pr/errordeveloper/fix-11690 into 7d26df1 on master.

@errordeveloper
Copy link
Copy Markdown
Contributor Author

errordeveloper commented Jun 2, 2020

Most Jenkins jobs have passed, I would say we can merge this. I am on the phone now, cannot check all the failures, it would be good to paste a summary here for the record.

@pchaigno
Copy link
Copy Markdown
Member

pchaigno commented Jun 2, 2020

Most failures seem to be related to failed to find plugin "cilium-cni" in path bug. It also hit known flake #11634. I think this is ready to merge w.r.t. to CI builds. Still missing a @cilium/ci review though.

@tgraf
Copy link
Copy Markdown
Contributor

tgraf commented Jun 2, 2020

The tests that failed, failed because of:

failed to find plugin "cilium-cni" in path [/opt/cni/bin]

@tgraf tgraf merged commit 6fe8d09 into master Jun 2, 2020
@tgraf tgraf deleted the pr/errordeveloper/fix-11690 branch June 2, 2020 14:04
@tklauser tklauser mentioned this pull request Jun 3, 2020
Merged
@pchaigno pchaigno mentioned this pull request Aug 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pchaigno pchaigno pchaigno approved these changes

+1 more reviewer

@tgraf tgraf tgraf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci/flake This is a known failure that occurs in the tree. Please investigate me! release-note/ci This PR makes changes to the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

v1.8: CI: K8sDatapathConfig Etcd Check connectivity

7 participants

@errordeveloper @coveralls @pchaigno @tgraf @tklauser @joestringer @b3a-dev