Skip to content

test: use local copy of Cilium Star Wars Demo#11817

Merged
nebril merged 2 commits intomasterfrom
pr/tklauser/starwars-demo-copy
Jun 2, 2020
Merged

test: use local copy of Cilium Star Wars Demo#11817
nebril merged 2 commits intomasterfrom
pr/tklauser/starwars-demo-copy

Conversation

@tklauser
Copy link
Copy Markdown
Member

@tklauser tklauser commented Jun 2, 2020

This avoids having to fetch the manifests from github and should help to
avoid some flakes due to external connectivity issues.

@tklauser tklauser added release-note/ci This PR makes changes to the CI. ci/flake This is a known failure that occurs in the tree. Please investigate me! labels Jun 2, 2020
@tklauser tklauser force-pushed the pr/tklauser/starwars-demo-copy branch from f38278f to fc4d1cc Compare June 2, 2020 10:59
@tklauser
Copy link
Copy Markdown
Member Author

tklauser commented Jun 2, 2020

test-focus K8sDemosTest

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 2, 2020

Coverage Status

Coverage decreased (-0.04%) to 36.891% when pulling c73db7f on pr/tklauser/starwars-demo-copy into 7d26df1 on master.

tklauser added 2 commits June 2, 2020 14:13
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
This avoids having to fetch the manifests from github and should help to
avoid some flakes due to external connectivity issues.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser force-pushed the pr/tklauser/starwars-demo-copy branch from fc4d1cc to c73db7f Compare June 2, 2020 12:14
@tklauser
Copy link
Copy Markdown
Member Author

tklauser commented Jun 2, 2020

test-focus K8sDemosTest

@tklauser tklauser marked this pull request as ready for review June 2, 2020 12:39
@tklauser tklauser requested review from a team as code owners June 2, 2020 12:39
Copy link
Copy Markdown
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for the documentation change too.

@tklauser
Copy link
Copy Markdown
Member Author

tklauser commented Jun 2, 2020

Focused test (K8sDemosTest) passed, so I think this is ready to merge.

@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 2, 2020
@nebril nebril merged commit 82fafa7 into master Jun 2, 2020
@nebril nebril deleted the pr/tklauser/starwars-demo-copy branch June 2, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/flake This is a known failure that occurs in the tree. Please investigate me! ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants