Skip to content

cilium: downgrade kernel_hz clock probe warning to info message#11816

Merged
aanm merged 1 commit intomasterfrom
pr/clock-probe-warn
Jun 2, 2020
Merged

cilium: downgrade kernel_hz clock probe warning to info message#11816
aanm merged 1 commit intomasterfrom
pr/clock-probe-warn

Conversation

@borkmann
Copy link
Copy Markdown
Member

@borkmann borkmann commented Jun 2, 2020

See commit msg.

@borkmann
cilium: downgrade kernel_hz clock probe warning to info message
d913f5f 
For the case where neither the kernel config can be determined nor derived
through probing, we currently emit a warning to the agent log. To avoid
confusion downgrade to just an info message. It's harmless since this just
means we're using ktime in our datapath instead of jiffies. Given it's
useful for debugging, dump the err to the info message as well.

Reported-by: Rene Zbinden <rene.zbinden@postfinance.ch>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann borkmann added pending-review area/daemon Impacts operation of the Cilium daemon. labels Jun 2, 2020
@borkmann borkmann requested review from a team and aanm June 2, 2020 10:20
@maintainer-s-little-helper
Copy link
Copy Markdown

maintainer-s-little-helper Bot commented Jun 2, 2020

Please set the appropriate release note label.

3 similar comments
@maintainer-s-little-helper
Copy link
Copy Markdown

maintainer-s-little-helper Bot commented Jun 2, 2020

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link
Copy Markdown

maintainer-s-little-helper Bot commented Jun 2, 2020

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link
Copy Markdown

maintainer-s-little-helper Bot commented Jun 2, 2020

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link
Copy Markdown

maintainer-s-little-helper Bot commented Jun 2, 2020

Please set the appropriate release note label.

@borkmann borkmann added the release-note/misc This PR makes changes that have no direct user impact. label Jun 2, 2020
@borkmann
Copy link
Copy Markdown
Member Author

borkmann commented Jun 2, 2020

test-me-please

@pchaigno
Copy link
Copy Markdown
Member

pchaigno commented Jun 2, 2020

Do we need to run e2e tests for this? I'd expect make to be enough.

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 2, 2020

Coverage Status

Coverage decreased (-0.03%) to 36.9% when pulling d913f5f on pr/clock-probe-warn into 7d26df1 on master.

@aanm aanm merged commit e57ae1c into master Jun 2, 2020
@aanm aanm deleted the pr/clock-probe-warn branch June 2, 2020 12:54
@maintainer-s-little-helper maintainer-s-little-helper Bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 2, 2020
@tklauser tklauser mentioned this pull request Jun 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tklauser tklauser tklauser approved these changes

@pchaigno pchaigno pchaigno approved these changes

@aanm aanm aanm approved these changes

Assignees

No one assigned

Labels

area/daemon Impacts operation of the Cilium daemon. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@borkmann @pchaigno @coveralls @tklauser @aanm @joestringer