Remove hubble-cli sub-chart #11806
Merged
borkmann merged 2 commits intocilium:masterfrom Jun 2, 2020
seanmwinn:cilium-11805
Merged
Remove hubble-cli sub-chart #11806borkmann merged 2 commits intocilium:masterfrom seanmwinn:cilium-11805
borkmann merged 2 commits intocilium:masterfrom
seanmwinn:cilium-11805
Conversation
Contributor
|
this is blocked on #11784. once it's merged, test/k8sT/hubble.go needs to be updated a bit more. for example, https://github.com/cilium/cilium/blob/7a113cbb5d2fe446ccfae392ddc68d6247623465/test/k8sT/hubble.go#L179 needs to exec into the cilium pod to run the hubble command. |
aanm
approved these changes
Jun 2, 2020
… the cilium-agent container Fixes: #11805 Signed-off-by: Sean Winn <sean@isovalent.com>
The Hubble CLI is now part of the Cilium container image. Therefore we can invoke all Hubble commands from the Cilium container and remove the hubble-cli helpers. Co-authored-by: Sean Winn <sean@isovalent.com> Signed-off-by: Sean Winn <sean@isovalent.com> Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
Contributor
|
test-me-please |
Member
|
retest-runtime (hit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the hubble-cli sub-chart since the binary was packaged with the cilium-agent container and will not be released
Fixes: #11805
Signed-off-by: Sean Winn sean@isovalent.com