fix(datarace): Fix possible nil pointer dereference#11804
Merged
aanm merged 1 commit intocilium:masterfrom Jun 2, 2020
Merged
Conversation
|
Please set the appropriate release note label. |
This commit is to fix the recent changes after rebased. Related PR is cilium#11685. Basically, there was a check if Node is nil after calling mutex lock, which will cause nil pointer dereference. I just refactor the code to make sure underlying node is not nil before obtaining mutex lock. Relates to 5259ff7 Signed-off-by: Tam Mach <sayboras@yahoo.com>
a552790 to
5df72a9
Compare
Member
|
test-me-please Edit: net-next provisioning failure |
Member
|
retest-net-next |
pchaigno
approved these changes
Jun 2, 2020
Member
Author
|
@christarazi @pchaigno seems like the required jobs are passed now, please let me know if anything is required. Thanks. |
This was referenced Jun 3, 2020
Member
|
Removing the need to backport this to 1.7 as this race doesn't exist in the 1.7 tree. I erroneously thought that it would affect the 1.7 tree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is to fix the recent changes after rebased. Related PR
is #11685.
Basically, there was a check if Node is nil after calling mutex lock,
which will cause nil pointer dereference. I just refactor the code
to make sure underlying node is not nil before obtaining mutex lock.
Relates to 5259ff7
Signed-off-by: Tam Mach sayboras@yahoo.com